feat: Support edit api v2

[clepski]

• Support edit api v2
• Edit events v1 will be converted event v2, see here for details
• BREAKING CHANGE: Edit event v1 properties derived and checkValidity will be ignored
• BREAKING CHANGE: Edit API v1 validation is no longer supported (e.g. edit api v1 checked if an elements id was unique in the document)
• History addon now has a history state which includes editCount, canUndo and canRedo. The history addon is the owner of this state, before there were multiple components storing and changing editCount
• Remove Editing Mixin
• Write documentation for Edit API v2

[github-actions]

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-14 08:36 UTC

[michelguerin]

Wow, I see a lot of work to make this v2 happen ! Well done :)

Through my tests and your documentation I see that the new API doesn't check validity on each change, so it seems to be a by design decision before your implementation.
I might be wrong but I also doesn't see any validation trigger elsewhere : I can make modification and download my file without any validation.

I'm not very aware of the board decisions, but it seems to be a regression from the v1 perspective (that being said, it seems buggy in the actual instance with the v1, so it might be the reason of the removal)

[clepski]

Wow, I see a lot of work to make this v2 happen ! Well done :)

Through my tests and your documentation I see that the new API doesn't check validity on each change, so it seems to be a by design decision before your implementation. I might be wrong but I also doesn't see any validation trigger elsewhere : I can make modification and download my file without any validation.

I'm not very aware of the board decisions, but it seems to be a regression from the v1 perspective (that being said, it seems buggy in the actual instance with the v1, so it might be the reason of the removal)

The missing validate event after edit events is a bug, thanks for catching it. I will look into fixing the functionality.

The validation before editing (like checking if ids are unique on create etc) are dropped on purpose.

[michelguerin]

Wow, I see a lot of work to make this v2 happen ! Well done :)
Through my tests and your documentation I see that the new API doesn't check validity on each change, so it seems to be a by design decision before your implementation. I might be wrong but I also doesn't see any validation trigger elsewhere : I can make modification and download my file without any validation.
I'm not very aware of the board decisions, but it seems to be a regression from the v1 perspective (that being said, it seems buggy in the actual instance with the v1, so it might be the reason of the removal)

The missing validate event after edit events is a bug, thanks for catching it. I will look into fixing the functionality.

The validation before editing (like checking if ids are unique on create etc) are dropped on purpose.

Wow, it was just due to the missing async keyword ? Haha... 🥲
Well done :)