Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(monorepo): Add contributing guide #1588

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Conversation

michelguerin
Copy link
Contributor

Details the installation steps to contribute as a developer.

  • Link from readme to contributing guide + refacto
  • Add .env.example file for needed environment variables
  • Add .env to .gitignore

* Link from readme to contributing guide + refacto
* Add .env.example file for needed environment variables
* Add `.env` to `.gitignore`
@michelguerin michelguerin requested a review from clepski November 8, 2024 12:14
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@michelguerin michelguerin requested a review from clepski November 8, 2024 15:52
README.md Show resolved Hide resolved
@trusz
Copy link
Member

trusz commented Nov 12, 2024

We already have a CONTRIBUTING.md in the core package: https://github.com/openscd/open-scd/blob/main/packages/core/CONTRIBUTING.md

Have you took that into consideration?

@michelguerin
Copy link
Contributor Author

We already have a CONTRIBUTING.md in the core package: https://github.com/openscd/open-scd/blob/main/packages/core/CONTRIBUTING.md

Have you took that into consideration?

Oups, didn't see this. I'll merge these to file in favor of the root one. I'll make a new proposition in the next commit.

@michelguerin michelguerin requested a review from trusz November 22, 2024 12:44
@michelguerin
Copy link
Contributor Author

@trusz Update done : I removed the contributing guide from the core package and merge its content to root.

@trusz trusz merged commit dd692a8 into openscd:main Dec 16, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants