Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about Data Prepper versus ingest processors #6886

Merged
merged 7 commits into from
Apr 11, 2024
Merged

Conversation

vagimeli
Copy link
Contributor

@vagimeli vagimeli commented Apr 4, 2024

Description

Clarifies when to use Data Prepper instead of OpenSearch ingestion processors

Issues Resolved

Closes #6429

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vagimeli vagimeli self-assigned this Apr 4, 2024
@vagimeli vagimeli added 3 - Tech review PR: Tech review in progress 4 - Doc review PR: Doc review in progress backport 2.13 PR: Backport label for 2.13 labels Apr 4, 2024
@vagimeli
Copy link
Contributor Author

vagimeli commented Apr 4, 2024

@Naarcha-AWS Please review this PR at your availability. I added notes to clarify using Data Prepper processors versus OpenSearch ingestion processors. Thank you.

@vagimeli
Copy link
Contributor Author

vagimeli commented Apr 9, 2024

@Naarcha-AWS Following up to get your doc review. Thanks!

Copy link
Collaborator

@Naarcha-AWS Naarcha-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vagimeli vagimeli added 5 - Editorial review PR: Editorial review in progress and removed 3 - Tech review PR: Tech review in progress 4 - Doc review PR: Doc review in progress labels Apr 10, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vagimeli vagimeli removed the 5 - Editorial review PR: Editorial review in progress label Apr 11, 2024
@vagimeli vagimeli merged commit 4957271 into main Apr 11, 2024
6 checks passed
@vagimeli vagimeli deleted the add-note branch April 11, 2024 17:41
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 11, 2024
* Add note about Data Prepper versus ingest

Signed-off-by: Melissa Vagi <[email protected]>

* Add note about Data Prepper versus ingest

Signed-off-by: Melissa Vagi <[email protected]>

---------

Signed-off-by: Melissa Vagi <[email protected]>
(cherry picked from commit 4957271)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.13 PR: Backport label for 2.13
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Updates to ingestion/Data Prepper documentation
4 participants