Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supported regions for Migration Assistant #9017

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Jan 4, 2025

Description

Add supported regions for Migration Assistant with GovCloud limitations

Issues Resolved

Closes MIGRATIONS-2293

Version

Migration Assistant 2.1.1

Frontend features

N/A

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

github-actions bot commented Jan 4, 2025

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@Naarcha-AWS Naarcha-AWS added backport 2.18 PR: Backport label for 2.18 4 - Doc review PR: Doc review in progress labels Jan 6, 2025
Copy link
Member

@chelma chelma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks Andre!

@Naarcha-AWS Naarcha-AWS merged commit 984e2c3 into opensearch-project:main Jan 7, 2025
7 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.18 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.18 2.18
# Navigate to the new working tree
pushd ../.worktrees/backport-2.18
# Create a new branch
git switch --create backport/backport-9017-to-2.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 984e2c3bc149f60d29f735ff29026577df57c47f
# Push it to GitHub
git push --set-upstream origin backport/backport-9017-to-2.18
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.18

Then, create a pull request where the base branch is 2.18 and the compare/head branch is backport/backport-9017-to-2.18.

Naarcha-AWS pushed a commit that referenced this pull request Jan 8, 2025
* Add supported regions for Migration Assistant

Signed-off-by: Andre Kurait <[email protected]>

* Update is-migration-assistant-right-for-you.md

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: Andre Kurait <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
(cherry picked from commit 984e2c3)
Naarcha-AWS added a commit that referenced this pull request Jan 8, 2025
Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS added a commit that referenced this pull request Jan 8, 2025
* Backort #9017

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Doc review PR: Doc review in progress backport 2.18 PR: Backport label for 2.18
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants