-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect documentation about query cache stats #9021
Fix incorrect documentation about query cache stats #9021
Conversation
Signed-off-by: Peter Alfonsi <[email protected]>
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @peteralfonsi! One suggestion.
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fix incorrect documentation about query cache stats Signed-off-by: Peter Alfonsi <[email protected]> * Update _api-reference/nodes-apis/nodes-stats.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> --------- Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> (cherry picked from commit 5f6a38c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.18 2.18
# Navigate to the new working tree
pushd ../.worktrees/backport-2.18
# Create a new branch
git switch --create backport/backport-9021-to-2.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5f6a38cddba13ef7bec0b99e0b17f62449518275
# Push it to GitHub
git push --set-upstream origin backport/backport-9021-to-2.18
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.18 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.18 2.18
# Navigate to the new working tree
pushd ../.worktrees/backport-2.18
# Create a new branch
git switch --create backport/backport-9021-to-2.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5f6a38cddba13ef7bec0b99e0b17f62449518275
# Push it to GitHub
git push --set-upstream origin backport/backport-9021-to-2.18
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.18 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.18 2.18
# Navigate to the new working tree
pushd ../.worktrees/backport-2.18
# Create a new branch
git switch --create backport/backport-9021-to-2.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5f6a38cddba13ef7bec0b99e0b17f62449518275
# Push it to GitHub
git push --set-upstream origin backport/backport-9021-to-2.18
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.18 Then, create a pull request where the |
…ct#9021) * Fix incorrect documentation about query cache stats Signed-off-by: Peter Alfonsi <[email protected]> * Update _api-reference/nodes-apis/nodes-stats.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> --------- Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: kolchfa-aws <[email protected]>
…ct#9021) * Fix incorrect documentation about query cache stats Signed-off-by: Peter Alfonsi <[email protected]> * Update _api-reference/nodes-apis/nodes-stats.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> --------- Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Russ Cam <[email protected]>
Description
Some of the descriptions for the query cache stats values returned in the nodes stats API are incorrect. This PR fixes them.
Issues Resolved
N/A, did not open an issue for this minor fix
Version
All versions that reference the query cache stats, which I believe is 1.3 onwards
Frontend features
N/A
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.