Fix index name in bitmap filtering docs #9032
Conversation
russcam
requested review from
kolchfa-aws,
Naarcha-AWS,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
There was a problem hiding this comment.
Thank you for making the docs better, @russcam! A small suggestion to keep the requests uniform.
|
@russcam Could you fix DCO so we can merge this PR? I just removed the extra lines between the code blocks and the includes. Thanks! |
|
@kolchfa-aws done |
|
Hey @russcam, looks like DCO is still failing, and you've picked up some extraneous commits. Could you please rebase and sign the commits that we want that are not signed? https://github.com/opensearch-project/documentation-website/pull/9032/checks?check_run_id=35404113474 Thanks so much! |
|
I can fix the issue that DCO has, but it requires me to sign commits that I haven't made (2604e82, ff96083). These extraneous commits are ones that have come in from the rebasing and merging that's been applied to the branch. I was in the process of addressing the review feedback, when GitHub was having issues, and these changes were made. A simple PR has been overcomplicated 🙂 |
Signed-off-by: Russ Cam <[email protected]> Signed-off-by: Russ Cam <[email protected]>
Add forward slashes to URLs Signed-off-by: Russ Cam <[email protected]> Signed-off-by: Russ Cam <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]> Signed-off-by: Russ Cam <[email protected]>
Signed-off-by: Saliha <[email protected]> Signed-off-by: Russ Cam <[email protected]>
Signed-off-by: Shawshark <[email protected]> Signed-off-by: Russ Cam <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]> Signed-off-by: Russ Cam <[email protected]>
…ct#9000) * docs: add validation requirement for message fields Add note clarifying that at least one field must be non-null and non-empty for successful message creation/update operations Signed-off-by: rithin-pullela-aws <[email protected]> * Update _ml-commons-plugin/api/memory-apis/create-message.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Rithin Pullela <[email protected]> --------- Signed-off-by: rithin-pullela-aws <[email protected]> Signed-off-by: Rithin Pullela <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Russ Cam <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Russ Cam <[email protected]>
…ion (opensearch-project#8982) * Update Linear and Logistic Regression Parameters & Improve Documentation - Add comprehensive documentation for supported: - Optimizers (SIMPLE_SGD, LINEAR_DECAY_SGD, etc.) - Objective types (ABSOLUTE_LOSS, HUBER, SQUARED_LOSS) - Momentum types (STANDARD, NESTEROV) - Fix parameter name typos Signed-off-by: rithin-pullela-aws <[email protected]> * Update _ml-commons-plugin/algorithms.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Rithin Pullela <[email protected]> * Added Tribuo documentation links to optimizers, Objective types, and momentum type. Signed-off-by: rithin-pullela-aws <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: rithin-pullela-aws <[email protected]> Signed-off-by: Rithin Pullela <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Russ Cam <[email protected]>
…h-project#9029) * Add support for Bedrock Rerank API opensearch-project#9027 Signed-off-by: tkykenmt <[email protected]> * Doc review Signed-off-by: Fanit Kolchina <[email protected]> * Change title Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * fix fieldname on Amazon Bedrock Rerank API output opensearch-project#9029 Signed-off-by: tkykenmt <[email protected]> --------- Signed-off-by: tkykenmt <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Russ Cam <[email protected]>
…ct#9021) * Fix incorrect documentation about query cache stats Signed-off-by: Peter Alfonsi <[email protected]> * Update _api-reference/nodes-apis/nodes-stats.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> --------- Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Russ Cam <[email protected]>
|
I think this may require an interactive rebase. Otherwise, do you want to close this PR and just raise a new one with the changes: might be easier. |
Description
Fix the name of the index used in some examples so that it is consistent with the surrounding documentation.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.