[Backport 2.x] Added minimum for search.cancel_after_time_interval setting for rollups #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…ps (#1026) * Added minimum for search.cancel_after_time_interval setting for rollups Signed-off-by: Joshua Au <[email protected]> * Added constant for cancel_after_time_interval for rollup search Signed-off-by: Joshua Au <[email protected]> * Handled case of default value for cancel interval Signed-off-by: Joshua Au <[email protected]> * Added comment explanation for default rollup cancel after time interval Signed-off-by: Joshua Au <[email protected]> * Fixed github workflow checks Signed-off-by: Joshua Au <[email protected]> --------- Signed-off-by: Joshua Au <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]> (cherry picked from commit 9b7b3bd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
bowenlan-amzn,
getsaurabh02,
lezzago,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
amsiglan,
sbcd90,
eirsep and
AWSHurneyt
as code owners
bowenlan-amzn
approved these changes
Nov 19, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1041 +/- ##
============================================
+ Coverage 74.83% 75.05% +0.21%
- Complexity 2872 2880 +8
============================================
Files 371 371
Lines 17013 17022 +9
Branches 2453 2453
============================================
+ Hits 12732 12776 +44
+ Misses 2920 2878 -42
- Partials 1361 1368 +7 ☔ View full report in Codecov by Sentry. |
Hailong-am
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 9b7b3bd from #1026.