Issue651 tests #1046

Joshua152 · 2023-11-22T21:54:55Z

*Issue #651 : *

Description of changes:
Added test for the byMetadata and parse methods and started implementation for the explain filter integration test.

CheckList:

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Au <[email protected]>

codecov · 2023-11-22T22:09:30Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (21f5f8d) 74.49% compared to head (00b6bd3) 74.92%.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1046      +/-   ##
============================================
+ Coverage     74.49%   74.92%   +0.43%     
- Complexity     2787     2812      +25     
============================================
  Files           367      367              
  Lines         16510    16518       +8     
  Branches       2358     2362       +4     
============================================
+ Hits          12299    12376      +77     
+ Misses         2905     2841      -64     
+ Partials       1306     1301       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bowenlan-amzn · 2023-11-24T02:44:47Z

...otlin/org/opensearch/indexmanagement/indexstatemanagement/resthandler/RestExplainActionIT.kt

+        val indexName2 = "${testIndexName}_filter2"
+        val indexName3 = "${testIndexName}_filter3"
+        val policy1 = createRandomPolicy()
+        val policy2 = createRandomPolicy() // create random policy with actions?


Yes, use specific action to make the failure behavior consistent/predictable

bowenlan-amzn · 2023-11-24T02:46:57Z

...otlin/org/opensearch/indexmanagement/indexstatemanagement/resthandler/RestExplainActionIT.kt

+        logger.info("Result2: $resp2")
+
+        // change the start time so the job will trigger in 2 seconds.
+        updateManagedIndexConfigStartTime(getExistingManagedIndexConfig(indexName1))


Seems there's some misunderstanding here. The life of an ISM job is
You create policy, apply to an index, it runs every <> minute by interval.
This updateManagedIndexConfigStartTime is just to help you in the test, so that don't need to wait the full interval. So you call this, then waitFor job running result, then call again, waitFor another running result.

Signed-off-by: Joshua Au <[email protected]>

bowenlan-amzn · 2023-12-02T17:37:10Z

...otlin/org/opensearch/indexmanagement/indexstatemanagement/resthandler/RestExplainActionIT.kt

+    }
+
+    fun `test explain filter on failed index`() {
+        val indexName = "${testIndexName}_failed"


Add another index that not failing

Signed-off-by: Joshua Au <[email protected]>

Signed-off-by: bowenlan-amzn <[email protected]>

bowenlan-amzn · 2023-12-14T21:45:17Z

@Joshua152 can you fix the check when you got time, thanks

Signed-off-by: Joshua Au <[email protected]>

bowenlan-amzn · 2023-12-14T23:43:09Z

Seems we introduce flakyness in explain IT, https://github.com/opensearch-project/index-management/actions/runs/7215557694/job/19660057561?pr=1046, will take another look later

Signed-off-by: Joshua Au <[email protected]>

* Implemented filtering on the ISM eplain API Signed-off-by: Joshua Au <[email protected]> * Fixed tests for ExplainRequest Signed-off-by: Joshua Au <[email protected]> * Added filtering on query and metadata map Signed-off-by: Joshua Au <[email protected]> * Filtered on indexNames in metadata Signed-off-by: Joshua Au <[email protected]> * Fixed github workflow check errors Signed-off-by: Joshua Au <[email protected]> * Removed debugging comments Signed-off-by: Joshua Au <[email protected]> * Updated code styling to make more clear Signed-off-by: Joshua Au <[email protected]> * Refactored code to match suggestions Signed-off-by: Joshua Au <[email protected]> * Added test case for the ExplainFilter.byMetaData and parse methods Signed-off-by: Joshua Au <[email protected]> * Started implementation of explain filter IT Signed-off-by: Joshua Au <[email protected]> * Implemented test explain filter method Signed-off-by: Joshua Au <[email protected]> * Implemented explain filter test on failure Signed-off-by: Joshua Au <[email protected]> * Cleaned up log statements Signed-off-by: Joshua Au <[email protected]> * Added explain filter test for success Signed-off-by: Joshua Au <[email protected]> * Fixed lint errors Signed-off-by: Joshua Au <[email protected]> * Removed policy from index to fix flaky tests Signed-off-by: Joshua Au <[email protected]> --------- Signed-off-by: Joshua Au <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]>

* Backport issue #998 to 2.x Signed-off-by: Joshua Au <[email protected]> * Issue651 tests (#1046) * Implemented filtering on the ISM eplain API Signed-off-by: Joshua Au <[email protected]> * Fixed tests for ExplainRequest Signed-off-by: Joshua Au <[email protected]> * Added filtering on query and metadata map Signed-off-by: Joshua Au <[email protected]> * Filtered on indexNames in metadata Signed-off-by: Joshua Au <[email protected]> * Fixed github workflow check errors Signed-off-by: Joshua Au <[email protected]> * Removed debugging comments Signed-off-by: Joshua Au <[email protected]> * Updated code styling to make more clear Signed-off-by: Joshua Au <[email protected]> * Refactored code to match suggestions Signed-off-by: Joshua Au <[email protected]> * Added test case for the ExplainFilter.byMetaData and parse methods Signed-off-by: Joshua Au <[email protected]> * Started implementation of explain filter IT Signed-off-by: Joshua Au <[email protected]> * Implemented test explain filter method Signed-off-by: Joshua Au <[email protected]> * Implemented explain filter test on failure Signed-off-by: Joshua Au <[email protected]> * Cleaned up log statements Signed-off-by: Joshua Au <[email protected]> * Added explain filter test for success Signed-off-by: Joshua Au <[email protected]> * Fixed lint errors Signed-off-by: Joshua Au <[email protected]> * Removed policy from index to fix flaky tests Signed-off-by: Joshua Au <[email protected]> --------- Signed-off-by: Joshua Au <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]> * Fixed content type import Signed-off-by: Joshua Au <[email protected]> * Implemented filtering on the ISM eplain API (#998) * Implemented filtering on the ISM eplain API Signed-off-by: Joshua Au <[email protected]> * Fixed tests for ExplainRequest Signed-off-by: Joshua Au <[email protected]> * Added filtering on query and metadata map Signed-off-by: Joshua Au <[email protected]> * Filtered on indexNames in metadata Signed-off-by: Joshua Au <[email protected]> * Fixed github workflow check errors Signed-off-by: Joshua Au <[email protected]> * Removed debugging comments Signed-off-by: Joshua Au <[email protected]> * Updated code styling to make more clear Signed-off-by: Joshua Au <[email protected]> * Refactored code to match suggestions Signed-off-by: Joshua Au <[email protected]> --------- Signed-off-by: Joshua Au <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]> * Issue651 tests (#1046) * Implemented filtering on the ISM eplain API Signed-off-by: Joshua Au <[email protected]> * Fixed tests for ExplainRequest Signed-off-by: Joshua Au <[email protected]> * Added filtering on query and metadata map Signed-off-by: Joshua Au <[email protected]> * Filtered on indexNames in metadata Signed-off-by: Joshua Au <[email protected]> * Fixed github workflow check errors Signed-off-by: Joshua Au <[email protected]> * Removed debugging comments Signed-off-by: Joshua Au <[email protected]> * Updated code styling to make more clear Signed-off-by: Joshua Au <[email protected]> * Refactored code to match suggestions Signed-off-by: Joshua Au <[email protected]> * Added test case for the ExplainFilter.byMetaData and parse methods Signed-off-by: Joshua Au <[email protected]> * Started implementation of explain filter IT Signed-off-by: Joshua Au <[email protected]> * Implemented test explain filter method Signed-off-by: Joshua Au <[email protected]> * Implemented explain filter test on failure Signed-off-by: Joshua Au <[email protected]> * Cleaned up log statements Signed-off-by: Joshua Au <[email protected]> * Added explain filter test for success Signed-off-by: Joshua Au <[email protected]> * Fixed lint errors Signed-off-by: Joshua Au <[email protected]> * Removed policy from index to fix flaky tests Signed-off-by: Joshua Au <[email protected]> --------- Signed-off-by: Joshua Au <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]> * Backport explain filter tests * Sleep thread to allow jobs to finish Signed-off-by: Joshua Au <[email protected]> --------- Signed-off-by: Joshua Au <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]>

Joshua152 added 10 commits October 26, 2023 12:38

Implemented filtering on the ISM eplain API

c06f95d

Signed-off-by: Joshua Au <[email protected]>

Fixed tests for ExplainRequest

c58d8d1

Signed-off-by: Joshua Au <[email protected]>

Added filtering on query and metadata map

2be9253

Signed-off-by: Joshua Au <[email protected]>

Filtered on indexNames in metadata

73af3b7

Signed-off-by: Joshua Au <[email protected]>

Fixed github workflow check errors

871952c

Signed-off-by: Joshua Au <[email protected]>

Removed debugging comments

f75579c

Signed-off-by: Joshua Au <[email protected]>

Updated code styling to make more clear

d4ca2c8

Signed-off-by: Joshua Au <[email protected]>

Refactored code to match suggestions

f6ba9dd

Signed-off-by: Joshua Au <[email protected]>

Added test case for the ExplainFilter.byMetaData and parse methods

1e6995f

Signed-off-by: Joshua Au <[email protected]>

Started implementation of explain filter IT

f559069

Signed-off-by: Joshua Au <[email protected]>

bowenlan-amzn reviewed Nov 24, 2023

View reviewed changes

Joshua152 added 3 commits December 1, 2023 18:18

Implemented test explain filter method

26eee41

Signed-off-by: Joshua Au <[email protected]>

Implemented explain filter test on failure

5d19093

Signed-off-by: Joshua Au <[email protected]>

Cleaned up log statements

f3e3bee

Signed-off-by: Joshua Au <[email protected]>

bowenlan-amzn reviewed Dec 2, 2023

View reviewed changes

Joshua152 and others added 2 commits December 2, 2023 14:52

Added explain filter test for success

44e553c

Signed-off-by: Joshua Au <[email protected]>

Merge branch 'main' into issue651-tests

4b454d9

bowenlan-amzn added the backport 2.x label Dec 3, 2023

Merge branch 'main' into issue651-tests

d6dd760

Signed-off-by: bowenlan-amzn <[email protected]>

Fixed lint errors

19796f0

Signed-off-by: Joshua Au <[email protected]>

Removed policy from index to fix flaky tests

00b6bd3

Signed-off-by: Joshua Au <[email protected]>

bowenlan-amzn marked this pull request as ready for review December 18, 2023 17:37

bowenlan-amzn requested review from getsaurabh02, lezzago, praveensameneni, xluo-aws and gaobinlong as code owners December 18, 2023 17:37

bowenlan-amzn requested review from Hailong-am, amsiglan, sbcd90, eirsep, AWSHurneyt and jowg-amazon as code owners December 18, 2023 17:37

bowenlan-amzn removed the backport 2.x label Dec 18, 2023

bowenlan-amzn approved these changes Dec 18, 2023

View reviewed changes

jowg-amazon approved these changes Dec 19, 2023

View reviewed changes

jowg-amazon merged commit 5aeed27 into opensearch-project:main Dec 19, 2023
24 of 25 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue651 tests #1046

Issue651 tests #1046

Joshua152 commented Nov 22, 2023

codecov bot commented Nov 22, 2023 •

edited

Loading

bowenlan-amzn Nov 24, 2023

bowenlan-amzn Nov 24, 2023

bowenlan-amzn Dec 2, 2023

bowenlan-amzn commented Dec 14, 2023

bowenlan-amzn commented Dec 14, 2023

Issue651 tests #1046

Issue651 tests #1046

Conversation

Joshua152 commented Nov 22, 2023

codecov bot commented Nov 22, 2023 • edited Loading

Codecov Report

bowenlan-amzn Nov 24, 2023

Choose a reason for hiding this comment

bowenlan-amzn Nov 24, 2023

Choose a reason for hiding this comment

bowenlan-amzn Dec 2, 2023

Choose a reason for hiding this comment

bowenlan-amzn commented Dec 14, 2023

bowenlan-amzn commented Dec 14, 2023

codecov bot commented Nov 22, 2023 •

edited

Loading