Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Rohit Ashiwal as code owner #1089

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

r1walz
Copy link
Collaborator

@r1walz r1walz commented Feb 5, 2024

Description of changes:

Adding Rohit Ashiwal as a code owner.

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rohit Ashiwal <[email protected]>
Copy link
Member

@bowenlan-amzn bowenlan-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have worked with Rohit for months on index management issues. Pretty sure he will be a good maintainer for this repo 👍

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a33173) 74.87% compared to head (e52a65c) 66.20%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1089      +/-   ##
============================================
- Coverage     74.87%   66.20%   -8.68%     
+ Complexity     2812     2416     -396     
============================================
  Files           367      367              
  Lines         16522    16522              
  Branches       2363     2363              
============================================
- Hits          12371    10938    -1433     
- Misses         2848     4447    +1599     
+ Partials       1303     1137     -166     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bowenlan-amzn
Copy link
Member

@opensearch-project/admin please help update the permission for Rohit.

@gaiksaya
Copy link
Member

gaiksaya commented Feb 5, 2024

@opensearch-project/admin please help update the permission for Rohit.

Done!

@bowenlan-amzn bowenlan-amzn merged commit ba24f86 into opensearch-project:main Feb 5, 2024
30 of 31 checks passed
@r1walz r1walz deleted the update-code-owners branch February 5, 2024 21:31
@r1walz
Copy link
Collaborator Author

r1walz commented Jul 29, 2024

Hi, @gaiksaya . Seems like I have been removed form opensearch-project. It may be since I left Amazon on Friday. Can you do the needful to add me back?

Add here as well: opensearch-project/index-management-dashboards-plugin#970

@gaiksaya
Copy link
Member

gaiksaya commented Jul 29, 2024

Hi, @gaiksaya . Seems like I have been removed form opensearch-project. It may be since I left Amazon on Friday. Can you do the needful to add me back?

Add here as well: opensearch-project/index-management-dashboards-plugin#970

Done and Done! You need to accept the invite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants