Added the fix for NPE happening during merges when all vector fields docs are deleted in the segments getting merged #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navneet1v
requested review from
heemin32,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng and
shatejas
as code owners
|
Checks failing |
navneet1v
added
Bug Fixes
vibrantvarun
reviewed
Jan 3, 2025
|
@jmazanec15 and @shatejas can you please take a look |
Vikasht34
reviewed
Jan 6, 2025
src/main/java/org/opensearch/knn/index/codec/util/KNNCodecUtil.java
Outdated
Show resolved
Hide resolved
shatejas
reviewed
Jan 6, 2025
src/test/java/org/opensearch/knn/index/codec/util/KNNCodecUtilTests.java
Outdated
Show resolved
Hide resolved
Vikasht34
approved these changes
Jan 6, 2025
src/main/java/org/opensearch/knn/index/codec/util/KNNCodecUtil.java
Outdated
Show resolved
Hide resolved
navneet1v
force-pushed
the
main
branch
2 times, most recently
from
4786914 to
641611e
Compare
…docs are deleted in the segments getting merged Signed-off-by: Navneet Verma <[email protected]>
jmazanec15
approved these changes
Jan 6, 2025
shatejas
approved these changes
Jan 6, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
…docs are deleted in the segments getting merged (#2365) Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 9fb7a5a)
navneet1v
added a commit
that referenced
this pull request
Jan 6, 2025
…docs are deleted in the segments getting merged (#2365) (#2371) Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 9fb7a5a) Co-authored-by: Navneet Verma <[email protected]>
Gankris96
pushed a commit
to Gankris96/k-NN
that referenced
this pull request
Jan 8, 2025
…docs are deleted in the segments getting merged (opensearch-project#2365) Signed-off-by: Navneet Verma <[email protected]>
owenhalpert
pushed a commit
to owenhalpert/k-NN
that referenced
this pull request
Jan 9, 2025
…docs are deleted in the segments getting merged (opensearch-project#2365) Signed-off-by: Navneet Verma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the fix for NPE happening during merges when all vector fields docs are deleted in the segments getting merged.
What is the bug:
Where there are a lot of deleted docs and we are trying to merge the segments, we are seeing the NPE exception coming as there were not docs containing vector and we are trying to iterate over vector values.
The issue is not always reproducible hence adding an IT is not possible here. Also with the changes add in 2.18 related to threshold based graph creation, the issue is now only limited to indices created <=2.16 version of Opensearch using BDV.
Attaching a script here(author: @jmazanec15 ) that helped in reproducing the issue.
merge-failure-2.sh.zip
Related Issues
NA
Check List
--signoff.Public documentation issue/PR created.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.