[Backport 2.x] Use one formula to calculate cosine similarity #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
opensearch-trigger-bot
bot
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas and
0ctopus13prime
as code owners
VijayanB
previously approved these changes
Jan 9, 2025
|
Github action is failing due to javadoc ( transient ) , however it is passing in java 21. |
VijayanB
force-pushed
the
backport/backport-2357-to-2.x
branch
from
add956e to
931670a
Compare
|
@VijayanB please fix the CI so that this change can be merged. |
please fix it |
naveentatikonda
previously approved these changes
Jan 14, 2025
VijayanB
dismissed stale reviews from naveentatikonda and themself
via
f7be348
VijayanB
force-pushed
the
backport/backport-2357-to-2.x
branch
from
931670a to
f7be348
Compare
* Have one score definition for cosinesimilarity Currently we have different score calculation for cosine similarity, for ex: script score, approximate search, exact search has diffent formula to convert distance to cosine similarity that is aligned with OpenSearch score. To keep it consistent, we will be using one defintion which is used by Lucene as standard definition for cosine similarity for all search types. Signed-off-by: Vijayan Balasubramanian <[email protected]> (cherry picked from commit 84cfa8e)
VijayanB
force-pushed
the
backport/backport-2357-to-2.x
branch
from
f7be348 to
5a2669f
Compare
VijayanB
approved these changes
Jan 15, 2025
naveentatikonda
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 84cfa8e from #2357