[Part 1] Fixed lint errors

package.json

@@ -18,7 +18,7 @@
     "cypress:run": "cypress run",
     "osd": "node ../../scripts/osd",
     "opensearch": "node ../../scripts/opensearch",
-    "lint": "node ../../scripts/eslint .",
+    "lint": "node ../../scripts/eslint",
     "plugin-helpers": "node ../../scripts/plugin_helpers",
     "test:jest": "../../node_modules/.bin/jest --config ./test/jest.config.js",
     "test:jest:dev": "../../node_modules/.bin/jest --watch --config ./test/jest.config.js",

public/components/Modal/Modal.test.tsx

@@ -8,10 +8,9 @@ import { EuiButton, EuiOverlayMask, EuiModal } from '@elastic/eui';
 import { render, fireEvent } from '@testing-library/react';
 import ModalRoot from './ModalRoot';
 import { ModalConsumer, ModalProvider } from './Modal';
-import { SecurityAnalyticsContext, SaContextConsumer } from '../../services';
+import { SecurityAnalyticsContext, SaContextConsumer, MetricsService } from '../../services';
 import services from '../../../test/mocks/services';
 import { MetricsContext } from '../../metrics/MetricsContext';
-import MetricsService from '../../services/MetricsService';
 import httpClientMock from '../../../test/mocks/services/httpClient.mock';
 
 describe('<ModalRoot /> spec', () => {

public/metrics/DetectorMetricsManager.ts

@@ -4,7 +4,7 @@
  */
 
 import { CreateDetectorSteps, CreateDetectorStepValue } from '../../types';
-import MetricsService from '../services/MetricsService';
+import { MetricsService } from '../services';
 
 export class DetectorMetricsManager {
   private static initialCheckpoint = CreateDetectorStepValue[CreateDetectorSteps.notStarted];
@@ -31,7 +31,7 @@ export class DetectorMetricsManager {
           [stepNameForCounter || step]: 1,
         },
       });
-      this.stepsLogged |= stepValue;
+      this.stepsLogged |= stepValue; // eslint-disable-line no-bitwise
     }
   }
 
@@ -40,6 +40,6 @@ export class DetectorMetricsManager {
   }
 
   private metricEmittedForStep(stepValue: number): boolean {
-    return (this.stepsLogged & stepValue) === stepValue;
+    return (this.stepsLogged & stepValue) === stepValue; // eslint-disable-line no-bitwise
   }
 }

public/metrics/MetricsContext.ts

@@ -3,7 +3,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import MetricsService from '../services/MetricsService';
+import { MetricsService } from '../services';
 import { DetectorMetricsManager } from './DetectorMetricsManager';
 
 export class MetricsContext {

public/models/interfaces.ts

@@ -15,10 +15,10 @@ import {
   NotificationsService,
   IndexPatternsService,
   LogTypeService,
+  CorrelationService,
+  MetricsService,
+  ThreatIntelService,
 } from '../services';
-import CorrelationService from '../services/CorrelationService';
-import MetricsService from '../services/MetricsService';
-import ThreatIntelService from '../services/ThreatIntelService';
 
 export interface BrowserServices {
   detectorsService: DetectorsService;

public/pages/Alerts/containers/Alerts/Alerts.tsx

@@ -40,8 +40,8 @@ import {
   DEFAULT_EMPTY_DATA,
   MAX_RECENTLY_USED_TIME_RANGES,
 } from '../../../../utils/constants';
-import AlertsService from '../../../../services/AlertsService';
-import DetectorService from '../../../../services/DetectorService';
+import { AlertsService } from '../../../../services/AlertsService';
+import { DetectorsService } from '../../../../services/DetectorService';
 import { AlertFlyout } from '../../components/AlertFlyout/AlertFlyout';
 import { CorrelationAlertFlyout } from '../../components/CorrelationAlertFlyout/CorrelationAlertFlyout';
 import {
@@ -85,7 +85,7 @@ type FilterAlertParams =
 
 export interface AlertsProps extends RouteComponentProps, DataSourceProps {
   alertService: AlertsService;
-  detectorService: DetectorService;
+  detectorService: DetectorsService;
   findingService: FindingsService;
   opensearchService: OpenSearchService;
   correlationService: CorrelationService;

public/pages/Alerts/containers/Alerts/__snapshots__/Alerts.test.tsx.snap

@@ -47,7 +47,14 @@ exports[`<Alerts /> spec renders the component 1`] = `
       "getFindings": [Function],
       "getThreatIntelFindings": [Function],
       "httpClient": [MockFunction],
-      "notifications": undefined,
+      "notifications": Object {
+        "toasts": Object {
+          "addDanger": [MockFunction],
+          "addInfo": [MockFunction],
+          "addSuccess": [MockFunction],
+          "addWarning": [MockFunction],
+        },
+      },
     }
   }
   match={[MockFunction]}
@@ -133,7 +140,14 @@ exports[`<Alerts /> spec renders the component 1`] = `
         "getFindings": [Function],
         "getThreatIntelFindings": [Function],
         "httpClient": [MockFunction],
-        "notifications": undefined,
+        "notifications": Object {
+          "toasts": Object {
+            "addDanger": [MockFunction],
+            "addInfo": [MockFunction],
+            "addSuccess": [MockFunction],
+            "addWarning": [MockFunction],
+          },
+        },
       }
     }
     history={

public/pages/CreateDetector/components/DefineDetector/components/DetectorDataSource/DetectorDataSource.tsx

@@ -11,17 +11,15 @@ import {
   EuiSpacer,
   EuiCallOut,
   EuiTextColor,
-  EuiTitle,
   EuiText,
 } from '@elastic/eui';
 import { FormFieldHeader } from '../../../../../../components/FormFieldHeader/FormFieldHeader';
 import { IndexOption } from '../../../../../Detectors/models/interfaces';
 import { MIN_NUM_DATA_SOURCES } from '../../../../../Detectors/utils/constants';
-import IndexService from '../../../../../../services/IndexService';
 import { NotificationsStart } from 'opensearch-dashboards/public';
 import { getDataSources } from '../../../../../../utils/helpers';
 import _ from 'lodash';
-import { FieldMappingService } from '../../../../../../services';
+import { FieldMappingService, IndexService } from '../../../../../../services';
 import { DataSourceProps } from '../../../../../../../types';
 
 interface DetectorDataSourceProps extends DataSourceProps {

public/pages/Detectors/components/UpdateFieldMappings/UpdateFieldMappings.tsx

@@ -5,9 +5,16 @@
 
 import React, { Component } from 'react';
 import { RouteComponentProps } from 'react-router-dom';
-import { EuiSmallButton, EuiFlexGroup, EuiFlexItem, EuiSpacer, EuiTitle, EuiText } from '@elastic/eui';
+import {
+  EuiSmallButton,
+  EuiFlexGroup,
+  EuiFlexItem,
+  EuiSpacer,
+  EuiTitle,
+  EuiText,
+} from '@elastic/eui';
 import { FieldMapping } from '../../../../../models/interfaces';
-import FieldMappingService from '../../../../services/FieldMappingService';
+import { FieldMappingService } from '../../../../services/FieldMappingService';
 import { DetectorHit, SearchDetectorsResponse } from '../../../../../server/models/interfaces';
 import { BREADCRUMBS, EMPTY_DEFAULT_DETECTOR, ROUTES } from '../../../../utils/constants';
 import { DetectorsService } from '../../../../services';

public/pages/Detectors/containers/Detector/__snapshots__/DetectorDetails.test.tsx.snap

@@ -226,7 +226,13 @@ exports[`<DetectorDetails /> spec renders the component 1`] = `
       "deleteVisualization": [Function],
       "getDashboard": [Function],
       "getDashboards": [Function],
-      "indexService": undefined,
+      "indexService": Object {
+        "getAliases": [MockFunction],
+        "getIndexFields": [MockFunction],
+        "getIndices": [Function],
+        "httpClient": [MockFunction],
+        "updateAliases": [MockFunction],
+      },
       "savedObjectsClient": Object {
         "delete": [MockFunction],
         "get": [MockFunction],
@@ -1042,7 +1048,13 @@ exports[`<DetectorDetails /> spec renders the component 1`] = `
         "deleteVisualization": [Function],
         "getDashboard": [Function],
         "getDashboards": [Function],
-        "indexService": undefined,
+        "indexService": Object {
+          "getAliases": [MockFunction],
+          "getIndexFields": [MockFunction],
+          "getIndices": [Function],
+          "httpClient": [MockFunction],
+          "updateAliases": [MockFunction],
+        },
         "savedObjectsClient": Object {
           "delete": [MockFunction],
           "get": [MockFunction],
@@ -1468,7 +1480,13 @@ exports[`<DetectorDetails /> spec renders the component 1`] = `
           "deleteVisualization": [Function],
           "getDashboard": [Function],
           "getDashboards": [Function],
-          "indexService": undefined,
+          "indexService": Object {
+            "getAliases": [MockFunction],
+            "getIndexFields": [MockFunction],
+            "getIndices": [Function],
+            "httpClient": [MockFunction],
+            "updateAliases": [MockFunction],
+          },
           "savedObjectsClient": Object {
             "delete": [MockFunction],
             "get": [MockFunction],
@@ -2743,7 +2761,13 @@ exports[`<DetectorDetails /> spec renders the component 1`] = `
           "deleteVisualization": [Function],
           "getDashboard": [Function],
           "getDashboards": [Function],
-          "indexService": undefined,
+          "indexService": Object {
+            "getAliases": [MockFunction],
+            "getIndexFields": [MockFunction],
+            "getIndices": [Function],
+            "httpClient": [MockFunction],
+            "updateAliases": [MockFunction],
+          },
           "savedObjectsClient": Object {
             "delete": [MockFunction],
             "get": [MockFunction],

public/pages/Detectors/containers/FieldMappings/EditFieldMapping.tsx

@@ -16,7 +16,7 @@ import {
 import FieldMappingsTable from '../../../CreateDetector/components/ConfigureFieldMapping/components/RequiredFieldMapping';
 import { ContentPanel } from '../../../../components/ContentPanel';
 import { FieldMapping } from '../../../../../models/interfaces';
-import FieldMappingService from '../../../../services/FieldMappingService';
+import { FieldMappingService } from '../../../../services/FieldMappingService';
 import { MappingViewType } from '../../../CreateDetector/components/ConfigureFieldMapping/components/RequiredFieldMapping/FieldMappingsTable';
 import { Detector } from '../../../../../types';
 import { FieldMappingsTableItem } from '../../../CreateDetector/models/interfaces';

public/pages/Rules/components/RuleEditor/DetectionVisualEditor.test.tsx

@@ -5,10 +5,34 @@
 
 import React from 'react';
 import { render } from '@testing-library/react';
+import { expect } from '@jest/globals';
 import { DetectionVisualEditor } from './DetectionVisualEditor';
 import DetectionVisualEditorMock from '../../../../../test/mocks/Rules/components/RuleEditor/DetectionVisualEditor.mock';
 
 describe('<SelectionExpField /> spec', () => {
+  beforeAll(() => {
+    function at(this: any[], n: number) {
+      // ToInteger() abstract op
+      n = Math.trunc(n) || 0;
+      // Allow negative indexing from the end
+      if (n < 0) n += this.length;
+      // OOB access is guaranteed to return undefined
+      if (n < 0 || n >= this.length) return undefined;
+      // Otherwise, this is just normal property access
+      return this[n];
+    }
+
+    const TypedArray = Reflect.getPrototypeOf(Int8Array);
+    for (const C of [Array, String, TypedArray]) {
+      Object.defineProperty((C as any).prototype, 'at', {
+        value: at,
+        writable: true,
+        enumerable: false,
+        configurable: true,
+      });
+    }
+  });
+
   it('renders the component', () => {
     const tree = render(<DetectionVisualEditor {...DetectionVisualEditorMock} />);
     expect(tree).toMatchSnapshot();

public/pages/ThreatIntel/containers/AddThreatIntelSource/AddThreatIntelSource.tsx

@@ -22,7 +22,7 @@ import {
 import { BREADCRUMBS, ROUTES, defaultIntervalUnitOptions } from '../../../../utils/constants';
 import { Interval } from '../../../CreateDetector/components/DefineDetector/components/DetectorSchedule/Interval';
 import { RouteComponentProps } from 'react-router-dom';
-import ThreatIntelService from '../../../../services/ThreatIntelService';
+import { ThreatIntelService } from '../../../../services';
 import {
   FileUploadSource,
   S3ConnectionSource,

public/pages/ThreatIntel/containers/Overview/ThreatIntelOverview.tsx

@@ -15,7 +15,6 @@ import {
   EuiTabbedContent,
   EuiTabbedContentTab,
   EuiText,
-  EuiTitle,
 } from '@elastic/eui';
 import React, { MouseEventHandler, useCallback, useEffect, useMemo } from 'react';
 import { BREADCRUMBS, ROUTES } from '../../../../utils/constants';
@@ -30,7 +29,7 @@ import { RouteComponentProps } from 'react-router-dom';
 import { ThreatIntelSourcesList } from '../../components/ThreatIntelSourcesList/ThreatIntelSourcesList';
 import { deriveFormModelFromConfig, getThreatIntelNextStepsProps } from '../../utils/helpers';
 import { ThreatIntelOverviewActions } from '../../components/ThreatIntelOverviewActions/ThreatIntelOverviewActions';
-import ThreatIntelService from '../../../../services/ThreatIntelService';
+import { ThreatIntelService } from '../../../../services';
 import { ThreatIntelLogScanConfig } from '../../components/ThreatIntelLogScanConfig/ThreatIntelLogScanConfig';
 import { setBreadcrumbs } from '../../../../utils/helpers';
 import { PageHeader } from '../../../../components/PageHeader/PageHeader';
@@ -237,7 +236,7 @@ export const ThreatIntelOverview: React.FC<ThreatIntelOverviewProps> = ({
         </EuiFlexGroup>
       </EuiAccordion>
       <EuiSpacer />
-      <EuiTabbedContent tabs={tabs} initialSelectedTab={tabs[0]} size="s"/>
+      <EuiTabbedContent tabs={tabs} initialSelectedTab={tabs[0]} size="s" />
       {flyoutContent && (
         <EuiFlyout onClose={() => setFlyoutContent(null)}>
           <EuiSpacer />

public/services/AlertsService.ts

@@ -16,15 +16,15 @@ import {
 import { dataSourceInfo } from './utils/constants';
 import { errorNotificationToast } from '../utils/helpers';
 
-export default class AlertsService {
+export class AlertsService {
   constructor(private httpClient: HttpSetup, private notifications: NotificationsStart) {}
 
   getAlerts = async (
     getAlertsParams: GetAlertsParams
   ): Promise<ServerResponse<GetAlertsResponse>> => {
     const {
       detectorType,
-      detector_id,
+      detector_id, // eslint-disable-line @typescript-eslint/naming-convention
       size,
       sortOrder,
       startIndex,
@@ -59,9 +59,9 @@ export default class AlertsService {
 
   acknowledgeAlerts = async (
     alertIds: string[],
-    detector_id: string
+    detectorId: string
   ): Promise<ServerResponse<AcknowledgeAlertsResponse>> => {
-    const url = API.ACKNOWLEDGE_ALERTS.replace('{detector_id}', detector_id);
+    const url = API.ACKNOWLEDGE_ALERTS.replace('{detector_id}', detectorId);
     const body = JSON.stringify({ alerts: alertIds });
     return await this.httpClient.post(`..${url}`, {
       body,