Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Artifacts to upload should include the java version in its name to avoid conflicts #3239

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

[2.x] Artifacts to upload should include the java version in its name to avoid conflicts #3239

wants to merge 1 commit into from

Conversation

LantaoJin
Copy link
Member

@LantaoJin LantaoJin commented Jan 10, 2025 •
edited
Loading

Description

Adding java version to the name of artifact to avoid conflicts in CI workflow. (Align with main branch)

Related Issues

Resolves #3238

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@LantaoJin LantaoJin mentioned this pull request Jan 10, 2025
Merged
7 tasks
@LantaoJin LantaoJin added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Jan 10, 2025
@LantaoJin LantaoJin changed the title Artifacts to upload should include the java version in its name to avoid conflicts [2.x] Artifacts to upload should include the java version in its name to avoid conflicts Jan 10, 2025
@LantaoJin
Copy link
Member Author

CI failures fixed by #3236
cc @dai-chen @YANG-DB @noCharger @ykmr1224 @penghuo , let's merge this and #3236 to stabilize the CI workflows of 2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YANG-DB YANG-DB YANG-DB approved these changes

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

@ykmr1224 ykmr1224 Awaiting requested review from ykmr1224 ykmr1224 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LantaoJin @YANG-DB