Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

: OCPBUGS-44812: Add nodeslicepool #2570

Merged
merged 1 commit into from
Nov 21, 2024
Merged

: OCPBUGS-44812: Add nodeslicepool #2570

merged 1 commit into from
Nov 21, 2024

Conversation

bpickard22
Copy link
Contributor

Fast ranges needs the nodeslicepool crd, this adds that and updates the multus unit test to accommodate it

@bpickard22
Copy link
Contributor Author

cc @dougbtv

@bpickard22
Add nodeslicepool
23a19ce 
Fast ranges needs the nodeslicepool crd, this adds that and updates the
multus unit test to accomadate it

Signed-off-by: Benjamin Pickard <[email protected]>
@dougbtv
Copy link
Member

dougbtv commented Nov 20, 2024

/approve

@dougbtv
Copy link
Member

dougbtv commented Nov 20, 2024

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpickard22, dougbtv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
@bpickard22
Copy link
Contributor Author

/retest-required

@dougbtv
Copy link
Member

dougbtv commented Nov 20, 2024

/retitle: OCPBUGS-44812: Add nodeslicepool

@openshift-ci openshift-ci bot changed the title Add nodeslicepool : OCPBUGS-44812: Add nodeslicepool Nov 20, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 20, 2024
@openshift-ci-robot
Copy link
Contributor

@bpickard22: This pull request references Jira Issue OCPBUGS-44812, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fast ranges needs the nodeslicepool crd, this adds that and updates the multus unit test to accommodate it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@knobunc
Copy link
Contributor

knobunc commented Nov 20, 2024

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 20, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8bfae3d and 2 for PR HEAD 23a19ce in total

@zshi-redhat
Copy link
Contributor

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@bpickard22: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial 23a19ce link false /test e2e-aws-ovn-serial
ci/prow/e2e-network-mtu-migration-ovn-ipv6 23a19ce link false /test e2e-network-mtu-migration-ovn-ipv6
ci/prow/e2e-aws-hypershift-ovn-kubevirt 23a19ce link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 23a19ce link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/security 23a19ce link false /test security
ci/prow/e2e-vsphere-ovn 23a19ce link false /test e2e-vsphere-ovn
ci/prow/e2e-aws-ovn-single-node 23a19ce link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e750244 into openshift:master Nov 21, 2024
28 of 35 checks passed
@openshift-ci-robot
Copy link
Contributor

@bpickard22: Jira Issue OCPBUGS-44812: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44812 has been moved to the MODIFIED state.

In response to this:

Fast ranges needs the nodeslicepool crd, this adds that and updates the multus unit test to accommodate it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-network-operator
This PR has been included in build cluster-network-operator-container-v4.18.0-202411210535.p0.ge750244.assembly.stream.el9.
All builds following this will include this PR.

@bpickard22
Copy link
Contributor Author

/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link

@bpickard22: new pull request created: #2574

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship Awaiting requested review from danwinship

@jcaamano jcaamano Awaiting requested review from jcaamano

Assignees

@dougbtv dougbtv

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bpickard22 @dougbtv @openshift-ci-robot @knobunc @zshi-redhat @openshift-bot @openshift-cherrypick-robot