Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0.-fr1] Add required test variables into horizon.conf #237

Open
wants to merge 1 commit into
base: 18.0-fr1
Choose a base branch
from

Conversation

HanzJas
Copy link
Contributor

@HanzJas HanzJas commented Jan 13, 2025

Add required test variables/values which are used as default values for Horizon tests, into horizon.conf

Add required test variables into horizon.conf
Copy link
Contributor

openshift-ci bot commented Jan 13, 2025

Hi @HanzJas. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@HanzJas HanzJas changed the title Merge pull request #234 from HanzJas/main Add required test variables into horizon.conf Jan 13, 2025
@HanzJas HanzJas changed the title Add required test variables into horizon.conf [18.0.-fr1] Add required test variables into horizon.conf Jan 13, 2025
@HanzJas HanzJas marked this pull request as ready for review January 13, 2025 11:07
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/96d2cf237fc4408a8297a40c291b532e

✔️ openstack-meta-content-provider SUCCESS in 4h 04m 37s
tcib-crc-podified-edpm-baremetal TIMED_OUT in 3h 12m 12s
tcib-podified-multinode-edpm-deployment-crc TIMED_OUT in 3h 13m 47s

@ashu-011
Copy link
Contributor

/hold

@ashu-011
Copy link
Contributor

@HanzJas I don't see these 3 lines in changes that were in master https://github.com/openstack-k8s-operators/tcib/pull/237/files#diff-809c504cd2c10647c8d9d99635bedcefc111734dfa70ecee3bd7349ff6bbb683R7-R9 . Can you check once if they are needed or we somehow missed them in master branch

@HanzJas
Copy link
Contributor Author

HanzJas commented Jan 14, 2025

@ashu-011, I was little confused too because PR 7acdcfb from @lpiwowar is missing in FR1. This PR is changing paths of already existing files and variables from var/lib/tempest to usr/local/bin.
I discussed it with Lukas yesterday and he said to me that I need to cherry-pick only my changes with the original paths to be sure it will work.
I do not know why this PR is not in FR1. Maybe @lpiwowar can clarify it/approve it?

@lpiwowar
Copy link
Contributor

lpiwowar commented Jan 14, 2025

Hey @HanzJas and @ashu-011,

#233 is not on 18.0-fr1 because it needs openstack-k8s-operators/test-operator#256 on 18.0-fr1 as well. It is planned for those changes to land in 18.0-fr2.

If @HanzJas cherry-picked his PR to 18.0-fr1 together with my changes it would lead to failures in some jobs because openstack-k8s-operators/test-operator#256 would be missing.

You can see that on 18.0-fr1 the paths to entrypoint scripts are still unchanged ->

tcib_entrypoint: /var/lib/horizontest/run_horizontest.sh

@lpiwowar
Copy link
Contributor

/ok-to-test

@lpiwowar
Copy link
Contributor

recheck

@ashu-011
Copy link
Contributor

Thank you for the clarification @lpiwowar

Copy link
Collaborator

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, ashu-011, HanzJas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/70ef0b8872c34d918551b88761791267

✔️ openstack-meta-content-provider SUCCESS in 4h 09m 02s
tcib-crc-podified-edpm-baremetal TIMED_OUT in 3h 11m 42s
tcib-podified-multinode-edpm-deployment-crc TIMED_OUT in 3h 13m 09s

@HanzJas
Copy link
Contributor Author

HanzJas commented Jan 14, 2025

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4eb9d36e74ec4e58abe5119d6b2b9b44

✔️ openstack-meta-content-provider SUCCESS in 4h 06m 55s
tcib-crc-podified-edpm-baremetal RETRY_LIMIT in 22m 22s
tcib-podified-multinode-edpm-deployment-crc TIMED_OUT in 3h 12m 27s

@ashu-011
Copy link
Contributor

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f3dc7034fe7a4d4fa067efde6ff4c2f3

✔️ openstack-meta-content-provider SUCCESS in 4h 11m 15s
tcib-crc-podified-edpm-baremetal TIMED_OUT in 3h 11m 07s
tcib-podified-multinode-edpm-deployment-crc TIMED_OUT in 3h 12m 19s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants