-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0.-fr1] Add required test variables into horizon.conf #237
base: 18.0-fr1
Are you sure you want to change the base?
[18.0.-fr1] Add required test variables into horizon.conf #237
Conversation
Add required test variables into horizon.conf
Hi @HanzJas. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/96d2cf237fc4408a8297a40c291b532e ✔️ openstack-meta-content-provider SUCCESS in 4h 04m 37s |
/hold |
@HanzJas I don't see these 3 lines in changes that were in master https://github.com/openstack-k8s-operators/tcib/pull/237/files#diff-809c504cd2c10647c8d9d99635bedcefc111734dfa70ecee3bd7349ff6bbb683R7-R9 . Can you check once if they are needed or we somehow missed them in master branch |
@ashu-011, I was little confused too because PR 7acdcfb from @lpiwowar is missing in FR1. This PR is changing paths of already existing files and variables from var/lib/tempest to usr/local/bin. |
#233 is not on 18.0-fr1 because it needs openstack-k8s-operators/test-operator#256 on 18.0-fr1 as well. It is planned for those changes to land in 18.0-fr2. If @HanzJas cherry-picked his PR to 18.0-fr1 together with my changes it would lead to failures in some jobs because openstack-k8s-operators/test-operator#256 would be missing. You can see that on 18.0-fr1 the paths to entrypoint scripts are still unchanged ->
|
/ok-to-test |
recheck |
Thank you for the clarification @lpiwowar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, ashu-011, HanzJas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/70ef0b8872c34d918551b88761791267 ✔️ openstack-meta-content-provider SUCCESS in 4h 09m 02s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4eb9d36e74ec4e58abe5119d6b2b9b44 ✔️ openstack-meta-content-provider SUCCESS in 4h 06m 55s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f3dc7034fe7a4d4fa067efde6ff4c2f3 ✔️ openstack-meta-content-provider SUCCESS in 4h 11m 15s |
Add required test variables/values which are used as default values for Horizon tests, into horizon.conf