Fix/charge-for-swap-before-schedule #1141
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, we only try to charge the key swap cost after a coldkey is already scheduled to be swapped. This means the scheduled swap will fail if there is not enough balance in the coldkey for the cost.
However, we still let them schedule the swap.
This PR checks for the cost upfront so we don't need to worry about this anymore. Also adds a test for preventing the schedule call if the cost can't be paid.
This PR also provides the swap cost via the
swap_coldkey
call, so this can break any existing scheduled calls.This is meant to preserve the cost at the time of scheduling, while still charging if the swap_coldkey call is called directly.
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctly