[controller] add Thread controller interface for unified APIs #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Irving-cl
force-pushed
the
add_thread_controller_interface
branch
from
1bb443b to
d3b7f3b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2304 +/- ##
==========================================
- Coverage 55.77% 55.71% -0.07%
==========================================
Files 87 5 -82
Lines 6890 70 -6820
Branches 0 2 +2
==========================================
- Hits 3843 39 -3804
+ Misses 3047 29 -3018
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. |
wgtdkp
reviewed
May 29, 2024
Irving-cl
force-pushed
the
add_thread_controller_interface
branch
2 times, most recently
from
c43481e to
990f94b
Compare
superwhd
reviewed
May 29, 2024
Irving-cl
force-pushed
the
add_thread_controller_interface
branch
from
990f94b to
280b1f6
Compare
superwhd
reviewed
May 29, 2024
Irving-cl
force-pushed
the
add_thread_controller_interface
branch
from
280b1f6 to
2b4418c
Compare
superwhd
reviewed
May 29, 2024
Irving-cl
force-pushed
the
add_thread_controller_interface
branch
from
2b4418c to
8d63db7
Compare
wgtdkp
approved these changes
May 30, 2024
Irving-cl
force-pushed
the
add_thread_controller_interface
branch
from
8d63db7 to
390da55
Compare
jwhui
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines the Thread Controller Interface which is intended to
provide a set of unified, async thread control APIs for both NCP and
RCP cases.
This PR is a child PR of #2283. In this PR, only
GetDeviceRoleisadded.
HostRcpimplemented the interface and the dbus handler isupdated to directly call this unified API.