[controller] add ncp host #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Irving-cl
force-pushed
the
add_ncp_host
branch
5 times, most recently
from
40e0e02 to
33b3138
Compare
wgtdkp
reviewed
Jun 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2329 +/- ##
===========================================
- Coverage 55.77% 37.56% -18.22%
===========================================
Files 87 93 +6
Lines 6890 10560 +3670
Branches 0 763 +763
===========================================
+ Hits 3843 3967 +124
- Misses 3047 6392 +3345
- Partials 0 201 +201 ☔ View full report in Codecov by Sentry. |
superwhd
reviewed
Jun 14, 2024
Irving-cl
force-pushed
the
add_ncp_host
branch
2 times, most recently
from
06262dd to
56c7b7b
Compare
wgtdkp
approved these changes
Jun 18, 2024
Irving-cl
force-pushed
the
add_ncp_host
branch
3 times, most recently
from
44d1ac8 to
5cc76cb
Compare
jwhui
reviewed
Jun 19, 2024
abtink
approved these changes
Jun 20, 2024
Irving-cl
force-pushed
the
add_ncp_host
branch
4 times, most recently
from
92e54a9 to
6edaae2
Compare
jwhui
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
NcpHostclass which is the implementation ofThreadControllerunder NCP case.This PR updates
ThreadController::Createto createNcpHostunderthe NCP case, allowing
otbr-agentto start when the co-processor isa NCP, though no functionalities have been implemented yet.
This PR also adds a CI workflow to use expect script to test otbr-agent
in NCP case. For this PR, a simple test is added to start otbr-agent
with NCP (dry run) and check the co-processor version.
This PR is a subset of PR #2283