[mdns] refactor mDNS State subscription #2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Irving-cl
force-pushed
the
refactor_mdns_state_subscription
branch
from
ec07ca2 to
2756903
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2560 +/- ##
==========================================
- Coverage 55.77% 45.97% -9.81%
==========================================
Files 87 104 +17
Lines 6890 12392 +5502
Branches 0 904 +904
==========================================
+ Hits 3843 5697 +1854
- Misses 3047 6385 +3338
- Partials 0 310 +310 ☔ View full report in Codecov by Sentry. |
superwhd
reviewed
Oct 25, 2024
Irving-cl
force-pushed
the
refactor_mdns_state_subscription
branch
2 times, most recently
from
f211c4d to
d9a9c9d
Compare
superwhd
reviewed
Oct 28, 2024
Irving-cl
force-pushed
the
refactor_mdns_state_subscription
branch
from
d9a9c9d to
1de3e32
Compare
jwhui
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the mDNS State subscription using the Subject-Observer pattern.
The PR makes the state subscription more flexible. Currently the mDNS state is published in
Application::HandleMdnsState. Now we have both NCP and RCP case. This function will be difficult to implement. With this new pattern, we can register different observers during NCP/RCP initialization.