Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pd] disable PD daemon which caused mDNS disruptions #2662

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

yangsong-cnyn
Copy link
Contributor

This PR addresses the mDNS disruptions caused by the dhcp6_pd_daemon restarting dhcpcd on reference device. As a workaround, the daemon is disabled, and PD is enabled by default in the dhcpcd.conf file. This ensures the reference device as BR, always requests a prefix delegation upon network interface configuration.

@yangsong-cnyn yangsong-cnyn self-assigned this Jan 7, 2025
@yangsong-cnyn yangsong-cnyn requested a review from superwhd January 7, 2025 09:51
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.68%. Comparing base (2b41187) to head (c93946d).
Report is 921 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2662       +/-   ##
===========================================
- Coverage   55.77%   43.68%   -12.10%     
===========================================
  Files          87      106       +19     
  Lines        6890    13268     +6378     
  Branches        0      954      +954     
===========================================
+ Hits         3843     5796     +1953     
- Misses       3047     7164     +4117     
- Partials        0      308      +308     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yangsong-cnyn yangsong-cnyn force-pushed the disable_pd_daemon branch 2 times, most recently from 89982cb to 0dafd00 Compare January 8, 2025 04:06
@yangsong-cnyn yangsong-cnyn force-pushed the disable_pd_daemon branch 2 times, most recently from 18c1122 to a8d7b0d Compare January 9, 2025 02:14
@yangsong-cnyn yangsong-cnyn requested a review from superwhd January 9, 2025 02:28
@yangsong-cnyn yangsong-cnyn force-pushed the disable_pd_daemon branch 2 times, most recently from 620caba to a3ce618 Compare January 14, 2025 03:56
Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jwhui jwhui changed the title [pd] Disable PD daemon which caused mDNS disruptions [pd] disable PD daemon which caused mDNS disruptions Jan 16, 2025
@jwhui jwhui merged commit 68bfc01 into openthread:main Jan 16, 2025
32 checks passed
@yangsong-cnyn yangsong-cnyn deleted the disable_pd_daemon branch January 17, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants