Update dependencies and modernize the codebase #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the MSRV of the latest bitcoin_hashes.
Almost no problems here, which is nice.
These shouldn't be `# Heading`s because those display poorly in docs.rs output. Just use a word for the first line and let rustdoc decide how to format it.
Rust 2021 started with Rust 1.56. Our MSRV is 1.63. So move to 2021. No changes except the module improvements from Rust 2018.
This dependency is only used in the binary, not the library. To properly separate this we should use workspaces, but as an easy first step just make the dep optional. While we are at it, update to the latest version of env_logger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates a couple deps to the latest versions, makes
env_loggeroptional so that users of the library don't needlessly pull it in, and turns on a ton of cargo lints.