Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HeatingDevice inherit from Device #356

Merged
merged 6 commits into from
Apr 2, 2024

Conversation

CFenner
Copy link
Member

@CFenner CFenner commented Jan 21, 2024

This makes Device the common base class also for HeatingDevices.

tests/test_VitochargeVX3.py Outdated Show resolved Hide resolved
tests/test_VitochargeVX3.py Outdated Show resolved Hide resolved
tests/test_VitochargeVX3.py Outdated Show resolved Hide resolved
tests/test_VitochargeVX3.py Outdated Show resolved Hide resolved
tests/test_VitochargeVX3.py Outdated Show resolved Hide resolved
tests/test_VitochargeVX3.py Outdated Show resolved Hide resolved
tests/test_VitochargeVX3.py Outdated Show resolved Hide resolved
tests/test_VitochargeVX3.py Outdated Show resolved Hide resolved
tests/test_VitochargeVX3.py Outdated Show resolved Hide resolved
tests/test_VitochargeVX3.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Nibot1 Nibot1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@woehrl01 woehrl01 merged commit ffcd5e2 into openviess:master Apr 2, 2024
4 checks passed
@CFenner CFenner added the enhancement New feature or request label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants