fix(askar): secure environment get public key is now async #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TimoGlastra
reviewed
Nov 25, 2024
packages/askar/package.json
Outdated
| @@ -46,7 +46,7 @@ | |||
| }, | |||
| "peerDependencies": { | |||
| "@hyperledger/aries-askar-shared": "^0.2.3", | |||
| "@animo-id/expo-secure-environment": "^0.0.1-alpha.0" | |||
| "@animo-id/expo-secure-environment": "*" | |||
There was a problem hiding this comment.
this can cause issues, it's not fine to just use any version?
Signed-off-by: Timo Glastra <[email protected]>
berendsliedrecht
force-pushed
the
await-askar
branch
from
df6589e to
6642ea0
Compare
TimoGlastra
reviewed
Nov 25, 2024
| @@ -206,7 +206,7 @@ export abstract class AskarBaseWallet implements Wallet { | |||
|
|
|||
| // Generate a hardware-backed P-256 keypair | |||
| secureEnvironment.generateKeypair(kid) | |||
There was a problem hiding this comment.
Should also be awaited
TimoGlastra
reviewed
Nov 25, 2024
Signed-off-by: Timo Glastra <[email protected]>
TimoGlastra
merged commit bdc07e5
into
openwallet-foundation:main
13 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Berend Sliedrecht [email protected]