Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1.0 release #215

Merged
merged 2 commits into from
Sep 25, 2024
Merged

1.1.0 release #215

merged 2 commits into from
Sep 25, 2024

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Aug 19, 2024

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Description of Changes

1.1.0 release

CHANGELOG.rst Outdated Show resolved Hide resolved
- Deprecated ``/usr/sbin/openwisp_config`` in favor of
``/usr/sbin/openwisp-config`` to maintain consistency with other files
in the package. The path ``/usr/sbin/openwisp_config`` is now a symbolic
link to ``/usr/sbin/openwisp-config``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now a backward incompatible change due to #217

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming of the init.d script is backward incompatible. This script is still present.

https://github.com/openwisp/openwisp-config/pull/217/files#r1775225457

CHANGELOG.rst Outdated Show resolved Hide resolved
Signed-off-by: Gagan Deep <[email protected]>
Copy link

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In openwisp_agent line 693:
	return $result
               ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	return "$result"

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors
'shfmt ' found no issues.

@nemesifier nemesifier merged commit 19bcddd into master Sep 25, 2024
3 checks passed
@nemesifier nemesifier deleted the 1.1.0-release branch September 25, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants