Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Users registered with social login cannot set password #369 #383

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Jun 4, 2024

Users registered with social login would not have a password set. When they access the password change page, a message would be should to they users that they do not need to change password.

Closes #369

@coveralls
Copy link

Coverage Status

coverage: 97.929% (+0.006%) from 97.923%
when pulling 9672547 on issues/369-password-change-NoReverseMatch
into af6214e on master.

Users registered with social login would not have a password set.
When they access the password change page, a message would be
should to they users that they do not need to change password.

Closes #369
@pandafy pandafy force-pushed the issues/369-password-change-NoReverseMatch branch from 9672547 to e7ffee5 Compare June 4, 2024 18:14
@coveralls
Copy link

Coverage Status

coverage: 97.929% (+0.006%) from 97.923%
when pulling e7ffee5 on issues/369-password-change-NoReverseMatch
into af6214e on master.

@nemesifier nemesifier merged commit 975d2c6 into master Jun 5, 2024
20 checks passed
@nemesifier nemesifier deleted the issues/369-password-change-NoReverseMatch branch June 5, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[bug] Password change page can fail with NoReverseMatch
3 participants