Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Fixed flaky selenium test: test_autocomplete_shelf_filter #429

Merged
merged 3 commits into from
Jan 8, 2025
Merged

[tests] Fixed flaky selenium test: test_autocomplete_shelf_filter #429

merged 3 commits into from
Jan 8, 2025
+5 −0

Conversation

youhaveme9
Copy link
Contributor

@youhaveme9 youhaveme9 commented Jan 7, 2025 •
edited by nemesifier
Loading

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Closes #400

@coveralls
Copy link

Coverage Status

coverage: 96.18%. remained the same
when pulling 829f73b on youhaveme9:issues/400-flaky-test-autocomplete-shelf-filter
into 1011f52 on openwisp:master.

nemesifier
nemesifier approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@nemesifier nemesifier merged commit be0a28e into openwisp:master Jan 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Flaky test: test_autocomplete_shelf_filter
3 participants
@youhaveme9 @coveralls @nemesifier