Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddns-scripts: Add dnspod.cn-v3 #25619

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

FriesI23
Copy link
Contributor

@FriesI23 FriesI23 commented Dec 26, 2024

Maintainer: FriesI23 Qin / @FriesI23
Compile tested: should be universal, Debian 12, OpenWrt 23.05.05
Run tested: i386_pentium4, vm on proxmox 8.3 using openwrt.sh, OpenWrt 23.05

Also tested: aarch64_generic, NanoPi R4S, OpenWrt 23.05.04

Description:
ddns-scripts: add support for dnspod.tencentcloudapi.com (aka: dnspod.cn) API v3

This script copy from FriesI23/ddns-scripts_tencent_cloud which I maintain.

@FriesI23 FriesI23 force-pushed the ddns-scripts/dnspod-cn-v3 branch from 1175e3a to 3b18909 Compare December 26, 2024 09:12
@FriesI23 FriesI23 marked this pull request as ready for review December 26, 2024 10:07
@FriesI23 FriesI23 force-pushed the ddns-scripts/dnspod-cn-v3 branch 3 times, most recently from 3ea2bca to da75eb1 Compare December 26, 2024 12:05
@FriesI23
Copy link
Contributor Author

Use real name as project required.

@1715173329 1715173329 requested a review from feckert December 26, 2024 12:45
@FriesI23 FriesI23 force-pushed the ddns-scripts/dnspod-cn-v3 branch from da75eb1 to 700a45f Compare December 26, 2024 12:59
@FriesI23
Copy link
Contributor Author

Force re-submit to make commit and author match (try make name check pass without errors)...

@FriesI23 FriesI23 force-pushed the ddns-scripts/dnspod-cn-v3 branch from 700a45f to 371cbbd Compare December 27, 2024 04:58
@feckert
Copy link
Member

feckert commented Jan 2, 2025

Can you please use tabs instead of spaces. All other files in the ddns-scripts package do this.

@FriesI23 FriesI23 force-pushed the ddns-scripts/dnspod-cn-v3 branch from 371cbbd to c191be6 Compare January 2, 2025 11:35
@FriesI23
Copy link
Contributor Author

FriesI23 commented Jan 2, 2025

Can you please use tabs instead of spaces. All other files in the ddns-scripts package do this.

Done.

@FriesI23 FriesI23 force-pushed the ddns-scripts/dnspod-cn-v3 branch from c191be6 to 6a891ea Compare January 2, 2025 13:31
@feckert
Copy link
Member

feckert commented Jan 8, 2025

If this PR is merged, can you please rebase and increase the PKG_RELEASE by one so that we have 55.

Thanks

@FriesI23 FriesI23 force-pushed the ddns-scripts/dnspod-cn-v3 branch from 6a891ea to 4e3d35f Compare January 8, 2025 11:32
@FriesI23
Copy link
Contributor Author

FriesI23 commented Jan 8, 2025

If this PR is merged, can you please rebase and increase the PKG_RELEASE by one so that we have 55.

Thanks

Sure!

@feckert
Copy link
Member

feckert commented Jan 10, 2025

@FriesI23 I have merged the #25624. Can you please rebase and increment the PKG_RELEASE by one.
Thanks

@FriesI23 FriesI23 force-pushed the ddns-scripts/dnspod-cn-v3 branch from 4e3d35f to 10df4c1 Compare January 10, 2025 12:33
@FriesI23 FriesI23 force-pushed the ddns-scripts/dnspod-cn-v3 branch from 10df4c1 to 8818efe Compare January 10, 2025 12:36
@FriesI23
Copy link
Contributor Author

@FriesI23 I have merged the #25624. Can you please rebase and increment the PKG_RELEASE by one. Thanks

Done😉

@feckert feckert merged commit c1f247d into openwrt:master Jan 10, 2025
1 check passed
@feckert
Copy link
Member

feckert commented Jan 10, 2025

Thanks merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants