Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-9630] Fix: Code examples #273

Closed
wants to merge 4 commits into from

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Jul 21, 2023

Summary

  • fixes code examples

Test plan

n/a

Issues

n/a

[FSSDK-9630]

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 97.333%. remained the same when pulling c1e0803 on localheinz:fix/example into 04f5c20 on optimizely:master.

1 similar comment
@coveralls
Copy link

Coverage Status

coverage: 97.333%. remained the same when pulling c1e0803 on localheinz:fix/example into 04f5c20 on optimizely:master.

@mikechu-optimizely
Copy link
Contributor

Hey @localheinz , I'm looking to roll up your (kindly) provided PRs into a single PR from our side (we have quirkiness with running the full CI from external forks).

Before I can do that, though, please read and follow the CONTRIBUTING.md. Once you've filled out the CLA, ping me here please 👍

@mikechu-optimizely
Copy link
Contributor

Before I can do that, though, please read and follow the CONTRIBUTING.md. Once you've filled out the CLA, ping me here please 👍

I do not currently see your name in our CLA signed list @localheinz. Definitely, fill out the CLA form when you get a moment. I'm not allowed to use any open-source contributions without the submission…. Uggg 😩 Legal.

@localheinz
Copy link
Contributor Author

@mikechu-optimizely

Done!

@localheinz
Copy link
Contributor Author

@mikechu-optimizely

Would you like me to apply the changes from all of my pull requests here into a single pull request?

@mikechu-optimizely
Copy link
Contributor

@mikechu-optimizely

Would you like me to apply the changes from all of my pull requests here into a single pull request?

That'd be super helpful. Yes, please. I can pull them off your fork much more completely that way.

Thanks and cheers.

@localheinz
Copy link
Contributor Author

@mikechu-optimizely

I have cherry-picked the commits from #274, #275, and #276 into the branch for this pull request.

@mikechu-optimizely
Copy link
Contributor

Besten Dank, Herr!

I created our internal ticket (FSSDK-9630) to get this into the main branch.

@mikechu-optimizely
Copy link
Contributor

We'll be pointing this tomorrow and then rolling it into the next sprint (ahhh ceremonies and planning).

@mikechu-optimizely
Copy link
Contributor

Point given (thanks for shortening that for us). Moved into planning for the next sprint (starts next week)

@mikechu-optimizely
Copy link
Contributor

Yikes. This slipped through our planning. I just noticed it when preparing to cut a patch version.

Review looks good. I need to bring a copy into our org so our back-end CI tests run.

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikechu-optimizely mikechu-optimizely changed the title Fix: Code examples [FSSDK-9630] Fix: Code examples Dec 4, 2023
@localheinz localheinz force-pushed the fix/example branch 2 times, most recently from c162dbc to a76066d Compare December 4, 2023 15:55
@mikechu-optimizely
Copy link
Contributor

@localheinz Decided not to sort-packages and remove the ReturnTypeWillChange decorators?

@localheinz
Copy link
Contributor Author

@mikechu-optimizely

Rebased on top of master and forgot that you wanted commits cherry-picked into this branch.

@mikechu-optimizely
Copy link
Contributor

Thanks. Pulling this into the org so the CI runs....

@mikechu-optimizely
Copy link
Contributor

mikechu-optimizely commented Dec 4, 2023

I'm closing this PR in exchange for #281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants