-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSSDK-9630] Fix: Code examples #273
Conversation
1 similar comment
Hey @localheinz , I'm looking to roll up your (kindly) provided PRs into a single PR from our side (we have quirkiness with running the full CI from external forks). Before I can do that, though, please read and follow the CONTRIBUTING.md. Once you've filled out the CLA, ping me here please 👍 |
I do not currently see your name in our CLA signed list @localheinz. Definitely, fill out the CLA form when you get a moment. I'm not allowed to use any open-source contributions without the submission…. Uggg 😩 Legal. |
Done! |
Would you like me to apply the changes from all of my pull requests here into a single pull request? |
That'd be super helpful. Yes, please. I can pull them off your fork much more completely that way. Thanks and cheers. |
c1e0803
to
d7c677d
Compare
Besten Dank, Herr! I created our internal ticket (FSSDK-9630) to get this into the main branch. |
We'll be pointing this tomorrow and then rolling it into the next sprint (ahhh ceremonies and planning). |
Point given (thanks for shortening that for us). Moved into planning for the next sprint (starts next week) |
Yikes. This slipped through our planning. I just noticed it when preparing to cut a patch version. Review looks good. I need to bring a copy into our org so our back-end CI tests run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c162dbc
to
a76066d
Compare
@localheinz Decided not to |
a76066d
to
5d776a7
Compare
Rebased on top of |
Thanks. Pulling this into the org so the CI runs.... |
I'm closing this PR in exchange for #281 |
Summary
Test plan
n/a
Issues
n/a
[FSSDK-9630]