Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use junit-jupiter-api in test scope only #160

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

fwiesweg
Copy link
Contributor

@fwiesweg fwiesweg commented Oct 25, 2024

Having it as a runtime dependency increases the bundle size unnecessarily and may break downstream tests if they depend on cts and also use an incompatible junit version.

Error message when running mvn clean test in the depending project:

TestEngine with ID 'junit-jupiter' failed to discover tests

The issue can be mitigated by adding a <exclusion> tag to the respective dependency declaration, but simply correcting the scope solves the issue for all users of CTS.

        <dependency>
            <groupId>org.orbisgis</groupId>
            <artifactId>cts</artifactId>
            <version>1.7.1</version>
            <exclusions>
                <exclusion>
                    <groupId>org.junit.jupiter</groupId>
                    <artifactId>junit-jupiter-api</artifactId>
                </exclusion>
            </exclusions>
        </dependency>

Thanks for your great work!

Having it as a runtime dependency increases the bundle size unnecessary
and may break downstream tests if they depend on cts and also use an
incompatible junit version.
@ebocher
Copy link
Member

ebocher commented Nov 5, 2024

Thanks

@ebocher ebocher merged commit 8ede9de into orbisgis:master Nov 5, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants