Add dummy hash for AbsIdealSheaf
#4366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matthias Zach <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4366 +/- ##
==========================================
- Coverage 84.34% 84.34% -0.01%
==========================================
Files 651 651
Lines 86744 86749 +5
==========================================
+ Hits 73163 73167 +4
- Misses 13581 13582 +1
|
afkafkafk13
reviewed
Dec 1, 2024
| @@ -587,6 +587,11 @@ function ==(I::AbsIdealSheaf, J::AbsIdealSheaf) | |||
| return true | |||
| end | |||
|
|
|||
| function Base.hash(I::AbsIdealSheaf, h::UInt) | |||
| h = hash(scheme(I), h) | |||
There was a problem hiding this comment.
Just to be sure: You deliberately choose the hash-value of the scheme on which I is defined?
There was a problem hiding this comment.
This was the suggestion of @HechtiDerLachs. I assumed that this is some property that all == AbsIdealSheaves have in common
There was a problem hiding this comment.
Indeed, if you were looking precisely for something that == AbsIdealSheaves have in common (and usually many more..), this is certainly the case. So the choice makes sense.
afkafkafk13
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some progress towards #2222.