Use monitoring-mixins for dashboards and alerts #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we want to use this, then I would like to also add a check to make sure that checked in alerts and dashboards are in sync. |
janhorstmann
force-pushed
the
feature/monitoring-mixins
branch
from
fec59fd to
d9ac2d0
Compare
janhorstmann
force-pushed
the
feature/monitoring-mixins
branch
21 times, most recently
from
6117d5a to
299b20e
Compare
|
Waiting on prometheus/prometheus#15334 in order not to regress on the angular deprecation of grafana |
This was referenced Nov 9, 2024
Draft
Draft
janhorstmann
force-pushed
the
feature/monitoring-mixins
branch
from
299b20e to
b279b89
Compare
janhorstmann
force-pushed
the
feature/monitoring-mixins
branch
from
b279b89 to
c0a70b1
Compare
janhorstmann
force-pushed
the
feature/monitoring-mixins
branch
from
c0a70b1 to
574ca26
Compare
Monitoring-mixins ([1]) allow upstream collaboration on alerts and grafana dashboards and convergence on monitoring best practices through bundling mixins with the corresponding software. Downstream customization of alerts and dashboards may be done using jsonnet ([2]). Usage of jsonnet-bundler ([3]) gives a clear reference of where dashboards and alerts originated and which version is used through `.src/jsonnetfile.json` and `.src/jsonnetfile.lock.json`. [1] https://monitoring.mixins.dev/ [2] https://github.com/google/jsonnet [3] https://github.com/jsonnet-bundler/jsonnet-bundler Signed-off-by: Jan Horstmann <[email protected]>
With the proposed workflow mixin output is generated offline and checked into version control for direct usage. A test is added to check whether the generated rules and dashboards match the checked-in version. Additionally a check for the script generating the mixins is added. Signed-off-by: Jan Horstmann <[email protected]>
With the alerts of the added node-exporter mixin some alerts became redundant and are removed. Signed-off-by: Jan Horstmann <[email protected]>
With the alerts of the added prometheus-exporter mixin some alerts became redundant and are removed. Signed-off-by: Jan Horstmann <[email protected]>
janhorstmann
force-pushed
the
feature/monitoring-mixins
branch
from
574ca26 to
c265084
Compare
|
@berendt all upstream dashboard changes have merged. This is finally ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monitoring-mixins ([1]) allow upstream collaboration on alerts and grafana dashboards and convergence on monitoring best practices through bundling mixins with the corresponding software.
Downstream customization of alerts and dashboards may be done using jsonnet ([2]).
Usage of jsonnet-bundler ([3]) gives a clear reference of where dashboards and alerts originated and which version is used through
.src/jsonnetfile.jsonand.src/jsonnetfile.lock.json.[1]
https://monitoring.mixins.dev/
[2]
https://github.com/google/jsonnet
[3]
https://github.com/jsonnet-bundler/jsonnet-bundler