Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.10.0 - New menu system #537

Merged
merged 99 commits into from
Mar 19, 2024
Merged

2.10.0 - New menu system #537

merged 99 commits into from
Mar 19, 2024

Conversation

misternebula
Copy link
Member

@misternebula misternebula commented Jun 5, 2023 •
edited
Loading

OWML 2.10.0

New Menus

  • Introduced a whole new, easier to use, menu system.
    • Old menu system is still availabe for backwards compatibility.
    • New menu system is accessed through ModHelper.MenuHelper. Old menus are still located at ModHelper.Menus.

Smaller Changes

  • Added DefaultConfig to ModHelper.
  • Changed logs in ModAssets to be MessageType.Debug (removes "Loading asset bundle from ... " spam unless you have OWML in debug mode)
  • Added full OW version and OWML version to title screen

Fixes #515
Fixes #514
Fixes #500
Fixes #385 (?)

  • controller inputs on popups
    • inputs only don't work on input popup. but you need keyboard for that anyway sooo
  • can't go up from text input, only down

misternebula added 30 commits May 22, 2023 00:34
@misternebula
create rebinding helper
2d0b7c8
@misternebula
add to containers and modhelper
0dae760
@misternebula
update menus
c04d2a3
@misternebula
Update Readme.md
e232f42
@misternebula
add patch
1825229
@misternebula
stuff?
26587ba
@misternebula
aaaaa
5e2dac5
@misternebula
fix menu tab
7d9c5e1
@misternebula
fix position of submenu
3f619e2
@misternebula
actually make it affected by passed parameters (lol)
c3b6b30
@misternebula
add sub tab
e55bc8f
@misternebula
patches
b969389
@misternebula
add OpenOptionsAtTab
673c9c7
@misternebula
fix title button indexing
e1b46b2
@misternebula
destroy all option items in new sub tab
afc7c31
@misternebula
add checkbox inputs for OWML and mods
daa7694
@misternebula
add selectors, two button, start of slider, etc
ea6382e
@misternebula
add button, redo owml mods menu layout
b3c0b6b
@misternebula
make toggles with no labels into checkboxes
87a8be1
@misternebula
Merge pull request #536 from ow-mods/new-menus
77786a8 
new menus -> rebinding branch
@misternebula
stuff
7eaf152
@misternebula
remove rebinding stuff
fe97564
@misternebula
do a bunch of interfaces to get menus working with ModHelper
1bd4514
@misternebula
add label creation
46d96f3
@misternebula
make mod label into one line
93ba4af
@misternebula
add slider input
ea3bd21
@misternebula
make standard menus scrollable
4b85735
@misternebula
fix spacing and audio
b3d0544
@misternebula
add old interfaces + scripts back in
756b7d1
@misternebula
add back in old menus properly
f32951a
@misternebula misternebula changed the title New Menu System 2.10.0 - New menu system Feb 21, 2024
@Bwc9876
Copy link
Member

Bwc9876 commented Feb 21, 2024

Would writing documentation for this on the docs site be something you're willing to do?

@misternebula
Copy link
Member Author

Yup!

@misternebula misternebula marked this pull request as ready for review March 11, 2024 20:13
Raicuparta
Raicuparta reviewed Mar 19, 2024
View reviewed changes
src/OWML.ModHelper.Menus/ModMenus.cs
@@ -59,7 +59,7 @@ private void InitMainMenu(TitleScreenManager titleScreenManager)
MainMenu.Initialize(titleScreenManager);
var inputMenu = titleScreenManager.GetComponent<ProfileMenuManager>().GetValue<PopupInputMenu>("_createProfileConfirmPopup");
PopupManager.Initialize(inputMenu, MainMenu.OptionsMenu);
ModsMenu.Initialize(this, MainMenu);
//ModsMenu.Initialize(this, MainMenu);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover commented-out code

@misternebula misternebula merged commit 0f1c8aa into dev Mar 19, 2024
3 checks passed
@misternebula misternebula deleted the just-menus branch March 19, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raicuparta Raicuparta Raicuparta left review comments

@MegaPiggy MegaPiggy MegaPiggy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@misternebula @MegaPiggy @Bwc9876 @Raicuparta