Fixes a bug when using IE8 where the dom tree gets extra block elements ... #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts when normalizing a p-element. (The p-element got a child p-elements, which is not allowed, and the markup got corrupted.)
|
I'm not able to test this atm as I don't have a VM at home but could you run me through what your proposed fix does exactly? |
|
The fix defers the execution of the node text normalization. I think there are some timing issues with IE8, so the fix is a work around to run correctly in IE8. (This is not the first time where IE behaves strangely, and a setTimeout solves the problem.) |
|
Has this been integrated already? Can this be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The p-element got a child p-elements, which is not allowed, and the markup got corrupted.
To reproduce: (use native IE8, not IE9 in IE8 mode)
Go to http://jquery-spellchecker.badsyntax.co/ckeditor.html
Place the cursor between "great explorer" and "of the truth" in the paragraph. Hit enter.
Press spellchecker (ABC-button on the top of the editor).
Spellcheck the second paragraph (starting with 'of the truth'... Correct Noo, consequencses's and painful.
At either "consequencses's" or "painful", the normalize function will create an extra paragraph when normalizing the p-element.