Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add query for last observed event nonce #1029

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

byte-bandit
Copy link
Contributor

@byte-bandit byte-bandit commented Nov 10, 2023

Related Github tickets

Background

This adds a new GRPC query to retrieve the last observed event nonce from Paloma. Pigeons will use this information in order to build their own state.

Testing completed

  • Will be tested in TN together with the Pigeon change

Breaking changes

  • I have checked my code for breaking changes
  • If there are breaking changes, there is a supporting migration.

Copy link
Contributor

@taariq taariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed way more SIMPLER than the discussion around this issue. Is there more required? LGTM

@byte-bandit
Copy link
Contributor Author

byte-bandit commented Nov 10, 2023

This seemed way more SIMPLER than the discussion around this issue. Is there more required? LGTM

Complex problem, simple solution ;)

Pigeon will need an update to consume this information, but it won't be very demanding.

@taariq taariq merged commit 2cc4ec0 into palomachain:master Nov 10, 2023
2 checks passed
@taariq taariq deleted the clohr/gravity-event-nonce branch November 10, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants