Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Skyway CW bindings #1325

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Conversation

byte-bandit
Copy link
Contributor

@byte-bandit byte-bandit commented Jan 9, 2025

Related Github tickets

Background

This change refactors a large amount of the existing CW integration, fixes a bug introduced with the last update & introduces bindings for the Skyway module.

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes
  • If there are breaking changes, there is a supporting migration.

@byte-bandit byte-bandit requested a review from taariq January 9, 2025 17:38
@byte-bandit byte-bandit self-assigned this Jan 9, 2025
@taariq
Copy link
Contributor

taariq commented Jan 9, 2025

@byte-bandit looks like we have a panic in the CI?

=== Failed
=== FAIL: util/libwasm TestDispatchMsg/Scheduler_message (0.00s)

=== FAIL: util/libwasm TestDispatchMsg (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x2360d78]

Copy link
Contributor

@taariq taariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just found a quick spelling mistake.

x/scheduler/bindings/types/msg.go Outdated Show resolved Hide resolved
@byte-bandit byte-bandit requested a review from taariq January 9, 2025 18:10
@byte-bandit
Copy link
Contributor Author

That's what I get for updating the implementation without checking for running tests. Fixed.

Copy link
Contributor

@taariq taariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants