Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: make hypercall return none always #1516

Merged
merged 1 commit into from
Aug 2, 2024
Merged

FIX: make hypercall return none always #1516

merged 1 commit into from
Aug 2, 2024

Conversation

lacraig2
Copy link
Member

@lacraig2 lacraig2 commented Aug 1, 2024

Hypercaller always returns void so this change ensures that callback always returns void.

@AndrewQuijano
Copy link
Collaborator

AndrewQuijano commented Aug 2, 2024

@lacraig2

Quick thing, could you also please update 'workflow_run' to 'workflow_dispatch'
https://github.com/panda-re/panda/blob/dev/.github/workflows/publish_docker.yml#L4

Just to fix the publish_debian too while you get your fix in too

@AndrewFasano AndrewFasano merged commit 8a52b80 into dev Aug 2, 2024
8 checks passed
@AndrewFasano AndrewFasano deleted the fix_return branch August 2, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants