-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numpy v2 #584
Conversation
/condalock |
ml-notebook/packages.txt
Outdated
@@ -215,9 +214,7 @@ gcc_impl_linux-64==13.3.0 | |||
gcc_linux-64==13.3.0 | |||
gcm_filters==0.3.0 | |||
gcsfs==2024.9.0 | |||
gdal==3.9.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, gdal command line tools it turns out have been coming from pyogrio, with the latest release it's just libgdal-core
dependency https://github.com/geopandas/pyogrio/releases/tag/v0.10.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not just pyogrio
but also rasterio
has switched to libgdal-core
, see conda-forge/pyogrio-feedstock#48 and conda-forge/rasterio-feedstock#303.
/condalock |
ml-notebook/packages.txt
Outdated
@@ -215,9 +214,7 @@ gcc_impl_linux-64==13.3.0 | |||
gcc_linux-64==13.3.0 | |||
gcm_filters==0.3.0 | |||
gcsfs==2024.9.0 | |||
gdal==3.9.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not just pyogrio
but also rasterio
has switched to libgdal-core
, see conda-forge/pyogrio-feedstock#48 and conda-forge/rasterio-feedstock#303.
pangeo-notebook/environment.yml
Outdated
# temporarily drop for numpy>=2 (can use xvec instead) | ||
#- geocube |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, so geocube pinned to numpy<2
here - corteva/geocube#175, but the incompatibility should have been fixed in rasterio 1.4 at rasterio/rasterio#3109 if I'm reading correctly. Could open an issue on geocube
to check, but ok to temporarily remove for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but the incompatibility should have been fixed in rasterio 1.4 at rasterio/rasterio#3109 if I'm reading correctly. Could open an issue on geocube to check, but ok to temporarily remove for now.
That would be great! I took the lazy approach just to see if this was the last remaining hold-out :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened a PR to remove the numpy<2 pin at corteva/geocube#179 🤞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Geocube 0.7.0 is out - conda-forge/geocube-feedstock#41. I'll update the environment.yml file and re-lock
Partially revert 718d6c2 since geocube 0.7.0 support numpy=2 now.
/condalock |
/condalock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bring numpy v2 to pangeo-notebook. And nano by popular demand #576 :)