Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node to 16 #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Node to 16 #23

wants to merge 1 commit into from

Conversation

fgeronimo-panther
Copy link

Background

Per this thread, I noticed the deprecation notice for Node 12 and this PR is for updating this GitHub Action to use Node 16. I don't believe this fixes the original issue in the thread.

Changes

  • Remove trailing space in line 39
  • Update Node to 16

Testing

Do I need to bump action version?

3nvi
3nvi approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@3nvi 3nvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as long as you've tested that it still works. Bumping the version is not necessary as long as the CIs target the "latest/main" version of the action. If the workflows use a hardcoded version then yes, you need to bump it.

@fgeronimo-panther
Copy link
Author

[TODO] Test locally with Act before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3nvi 3nvi 3nvi approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgeronimo-panther @3nvi