sync changes from panther-labs/panther-enterprise#20592

panther-labs · Nov 25, 2024 · 15b98c1 · 15b98c1
1 parent b4391dd
commit 15b98c1
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/cloudformation/panther-deployment-role.yml b/cloudformation/panther-deployment-role.yml
@@ -326,7 +326,6 @@ Resources:
               - kms:DeleteImportedKeyMaterial
               - kms:ScheduleKeyDeletion
               - s3:DeleteBucket
-              - sns:DeleteTopic
             Resource: '*'
 Outputs:
   DeploymentRoleArn:

diff --git a/serverless/panther-preflight-tools/readiness-check/src/app.py b/serverless/panther-preflight-tools/readiness-check/src/app.py
@@ -165,14 +165,14 @@ def check_s3_select_readiness() -> bool:
     return s3check.is_enabled()
 
 
-def lambda_handler(_: dict[str, Any], __: Any) -> str:
+def lambda_handler(_: dict[str, Any], __: Any) -> dict:
     """
     Lambda entrypoint.  Accepts no input values. The "where" of it's running is
     the most important aspect.
     """
 
     return {
-        'deployment_role_readiness_results': check_deployment_role_readiness(_, __),
+        'deployment_role_readiness_results': check_deployment_role_readiness(),
         's3_select_enabled': check_s3_select_readiness()
     }
 

diff --git a/serverless/panther-preflight-tools/readiness-check/src/s3_select_check.py b/serverless/panther-preflight-tools/readiness-check/src/s3_select_check.py
@@ -86,7 +86,6 @@ def _setup_bucket(self):
             self.s3.create_bucket(Bucket=self.test_bucket_name)
             self.log.info(f'test s3 bucket ({self.test_bucket_name}) created without LocationConstraint')
 
-
     def _cleanup_bucket(self):
         self.log.info(f'cleaning up test s3 bucket ({self.test_bucket_name})')
         self.s3.delete_bucket(Bucket=self.test_bucket_name)