Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pants: upgrade Pants to 2.21.0 #18

Closed

Conversation

AlexTereshenkov
Copy link
Member

No description provided.

@AlexTereshenkov AlexTereshenkov marked this pull request as ready for review June 20, 2024 21:35
@sureshjoshi
Copy link
Member

sureshjoshi commented Jun 20, 2024

Wait, what? Aren't we already on 2.21?
Screenshot 2024-06-20 at 17 40 50

@huonw
Copy link
Contributor

huonw commented Jun 20, 2024

It does look like #17 did this already, but we forgot to update pantsbuild/pants#20970. Thanks @AlexTereshenkov, sorry for the wasted work!

@huonw huonw closed this Jun 20, 2024
@sureshjoshi
Copy link
Member

but we forgot to update

Yep, that sounds like me...

@kaos
Copy link
Member

kaos commented Jun 25, 2024

lesson to learn here: make sure your branch is up-to-date before branching out ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants