Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Fixes in last dependency get results. Add Slurm seff job. Fix permissions on patching results #65

Merged
merged 14 commits into from
Oct 21, 2024

Conversation

juanesarango
Copy link
Contributor

@juanesarango juanesarango commented Oct 14, 2024

By mistake I combined multiple changes, that should have been done in different PRs.

Some of the updates:

  • 🐛   Bug fix
  • 🚀   New feature
  • 🔧   Code refactor
  • ⚠️   Breaking change that would cause existing functionality to change
  • 📘   I have updated the documentation accordingly
  • ✅   I have added tests to cover my changes

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.48%. Comparing base (f13b995) to head (956af4b).

Files with missing lines Patch % Lines
isabl_cli/data.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   95.14%   95.48%   +0.33%     
==========================================
  Files          19       19              
  Lines        2368     2368              
==========================================
+ Hits         2253     2261       +8     
+ Misses        115      107       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanesarango juanesarango marked this pull request as ready for review October 21, 2024 19:49
@juanesarango juanesarango merged commit 8c8ad75 into master Oct 21, 2024
4 checks passed
@juanesarango juanesarango deleted the run-app-latest-dependency-version branch October 21, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant