Test against rails 8.0 #1498
Merged
Test against rails 8.0 #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skipkayhil
reviewed
Oct 19, 2024
| @@ -5,5 +5,9 @@ | |||
| class PostWithStatus < ApplicationRecord | |||
| has_paper_trail | |||
|
|
|||
| enum status: { draft: 0, published: 1, archived: 2 } | |||
| if ActiveRecord::VERSION::MAJOR >= 8 | |||
There was a problem hiding this comment.
Suggested change
| if ActiveRecord::VERSION::MAJOR >= 8 | |
| if ActiveRecord::VERSION::MAJOR >= 7 |
I think the new syntax was added in 7.0 so this would enable removing the condition sooner (when 6.1 is dropped)
skipkayhil
approved these changes
Oct 21, 2024
|
@fatkodima @skipkayhil should we go ahead and merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1490.
master(if not - rebase it).code introduces user-observable changes.
and description in grammatically correct, complete sentences.