Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Fix zombienet polkadot build #95

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Fix zombienet polkadot build #95

merged 5 commits into from
Nov 8, 2023

Conversation

khssnv
Copy link
Contributor

@khssnv khssnv commented Oct 26, 2023

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Oct 26, 2023

User @khssnv, please sign the CLA here.

@khssnv khssnv changed the title Fix polkadot build Fix zombienet polkadot build Oct 26, 2023
@khssnv khssnv marked this pull request as draft October 26, 2023 13:45
@khssnv khssnv marked this pull request as ready for review October 27, 2023 14:10
@stiiifff stiiifff requested review from Moliholy and weezy20 November 2, 2023 10:19
zombienet.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@weezy20 weezy20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the added complexity of a bash array needed? Isn't it simpler to just copy polkadot and the workers with 3 cp commands?

@khssnv
Copy link
Contributor Author

khssnv commented Nov 6, 2023

Is the added complexity of a bash array needed? Isn't it simpler to just copy polkadot and the workers with 3 cp commands?

Array expansion removed.

Moliholy
Moliholy previously approved these changes Nov 6, 2023
@Moliholy
Copy link
Contributor

Moliholy commented Nov 6, 2023

@stiiifff @weezy20 LGTM

zombienet.sh Outdated Show resolved Hide resolved
@stiiifff stiiifff enabled auto-merge (squash) November 7, 2023 11:58
auto-merge was automatically disabled November 7, 2023 14:13

Head branch was pushed to by a user without write access

@khssnv khssnv requested review from weezy20 and Moliholy November 7, 2023 14:14
Copy link
Contributor

@weezy20 weezy20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks @khssnv

@weezy20 weezy20 merged commit f378691 into paritytech:main Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants