Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enha: send original error response in ProxyGetRequest #1516

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open
21 changes: 16 additions & 5 deletions server/src/middleware/http/proxy_get_request.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ use hyper::header::{ACCEPT, CONTENT_TYPE};
use hyper::http::HeaderValue;
use hyper::{Method, Uri};
use jsonrpsee_core::BoxError;
use jsonrpsee_types::{Id, RequestSer};
use jsonrpsee_types::{ErrorObject, Id, RequestSer};
use std::collections::HashMap;
use std::future::Future;
use std::pin::Pin;
Expand Down Expand Up @@ -179,16 +179,27 @@ where
bytes.extend(data);
}

#[derive(serde::Deserialize)]
struct RpcPayload<'a> {
#[derive(serde::Deserialize, serde::Serialize, Debug)]
struct SuccessResponse<'a> {
#[serde(borrow)]
result: &'a serde_json::value::RawValue,
}

let response = if let Ok(payload) = serde_json::from_slice::<RpcPayload>(&bytes) {
#[derive(serde::Deserialize, serde::Serialize, Debug)]
struct ErrorResponse<'a> {
#[serde(borrow)]
error: &'a serde_json::value::RawValue,
dcfreire marked this conversation as resolved.
Show resolved Hide resolved
}

let response = if let Ok(payload) = serde_json::from_slice::<SuccessResponse>(&bytes) {
http::response::ok_response(payload.result.to_string())
} else {
http::response::internal_error()
serde_json::from_slice::<ErrorResponse>(&bytes)
.and_then(|payload| serde_json::from_str::<ErrorObject>(&payload.error.to_string()))
dcfreire marked this conversation as resolved.
Show resolved Hide resolved
.map_or_else(
|_| http::response::internal_error(),
|error| http::response::error_response(error.to_owned()),
)
};

Ok(response)
Expand Down
9 changes: 9 additions & 0 deletions server/src/transport/http.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

/// Returns true if the `content_type` header indicates a valid JSON message.
pub fn is_json(content_type: Option<&hyper::header::HeaderValue>) -> bool {
content_type.and_then(|val| val.to_str().ok()).map_or(false, |content| {

Check warning on line 21 in server/src/transport/http.rs

View workflow job for this annotation

GitHub Actions / Check style

this `map_or` is redundant

Check warning on line 21 in server/src/transport/http.rs

View workflow job for this annotation

GitHub Actions / Check style

this `map_or` is redundant
content.eq_ignore_ascii_case("application/json")
|| content.eq_ignore_ascii_case("application/json; charset=utf-8")
|| content.eq_ignore_ascii_case("application/json;charset=utf-8")
Expand Down Expand Up @@ -127,6 +127,15 @@
from_template(hyper::StatusCode::INTERNAL_SERVER_ERROR, error, JSON)
}

/// Create a json response for general errors returned by the called method.
pub fn error_response(error: ErrorObjectOwned) -> HttpResponse {
let err = ResponsePayload::<()>::error(error);
let rp = Response::new(err, Id::Null);
let error = serde_json::to_string(&rp).expect("JSON serialization infallible; qed");

from_template(hyper::StatusCode::INTERNAL_SERVER_ERROR, error, JSON)
}

/// Create a text/plain response for not allowed hosts.
pub fn host_not_allowed() -> HttpResponse {
from_template(hyper::StatusCode::FORBIDDEN, "Provided Host header is not whitelisted.\n", TEXT)
Expand Down
Loading