Dynamic memory allocation support; refactoring #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Zicond` extension ends up producing pretty bad code. For example,
the following piece of code:
```
fn func(a0: u32, a1: u32, a2: u32) -> u32 {
if a0 == 0 {
a1
} else {
a2
}
}
```
with `Zicond` produces *two* conditional moves and one `or`, while
with the `xtheadcondmov` it is a single conditional move and
a register to register move, as you'd expect.
The `Zicond` might be more in-line with RISC-V's philosophy of not
requiring more than two read ports per instruction, but we really
don't care, and this *does* produce a measurable and significant
performance difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52
Fixes #36
Reverts #80
Partially implements #72 (the
xtheadcondmovextension)