wof property wof:abbreviation was renamed wof:shortcode #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missinglink
force-pushed
the
wof_shortcode
branch
from
25dacb9 to
4ca15f0
Compare
|
Looks right, can you add one test showing that if |
missinglink
force-pushed
the
wof_shortcode
branch
from
4ca15f0 to
2191d93
Compare
|
Added a test case to confirm backwards compatibility |
|
Eyeball tested this on a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wof property
wof:abbreviationwas renamedwof:shortcode.we will need to leave both the old and new fields in the code in case users would like to build from new code against old data.
after a period of >1 month we should remove the now deprecated
wof:abbreviationproperty