Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translations for activity logs #907

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Boy132
Copy link
Member

@Boy132 Boy132 commented Jan 13, 2025

Closes #897

Needs pelican-dev/wings#59 in order for sftp file events to work.

@Boy132 Boy132 self-assigned this Jan 13, 2025
@Boy132 Boy132 marked this pull request as ready for review January 13, 2025 10:55
Copy link
Contributor

@RMartinOscar RMartinOscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Try deleting a file using the recyclebin on the right, it works for bulkaction but not the single one

image

Try renaming a file within a dir

Man idk what's wrong with my gh it keeps Approving & clear my comment when i request changes

Running on wings canary with Quinten

    metadata := make(map[string]interface{})

    // Check if the target is empty
    if fa.Target == "" {
        // Only include the "files" key when no target is provided
        metadata["files"] = []string{fa.Entity}
    } else {
        // Include "from" and "to" fields when a target exists
        metadata["from"] = fa.Entity
        metadata["to"] = fa.Target
    }

@Boy132 Boy132 requested a review from RMartinOscar January 15, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate activity log event with properties
3 participants