-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix translations for activity logs #907
Open
Boy132
wants to merge
6
commits into
main
Choose a base branch
from
boy132/activity-log-properties
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+97
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RMartinOscar
requested changes
Jan 13, 2025
app/Filament/Server/Resources/ActivityResource/Pages/ListActivities.php
Outdated
Show resolved
Hide resolved
lancepioch
approved these changes
Jan 13, 2025
RMartinOscar
approved these changes
Jan 13, 2025
RMartinOscar
requested changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try deleting a file using the recyclebin on the right, it works for bulkaction but not the single one
Try renaming a file within a dir
Man idk what's wrong with my gh it keeps Approving & clear my comment when i request changes
Running on wings canary with Quinten
metadata := make(map[string]interface{})
// Check if the target is empty
if fa.Target == "" {
// Only include the "files" key when no target is provided
metadata["files"] = []string{fa.Entity}
} else {
// Include "from" and "to" fields when a target exists
metadata["from"] = fa.Entity
metadata["to"] = fa.Target
}
lancepioch
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #897
Needs pelican-dev/wings#59 in order for sftp file events to work.