Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the docker build #917

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

QuintenQVD0
Copy link
Contributor

Changes

  • Implement a multi-stage build: first, use Composer to handle dependencies, then build assets with Yarn and Vite, followed by creating the final container.
  • The sequence is critical since Vite requires Composer dependencies to function correctly.
  • Specify the platform explicitly where necessary for better compatibility.
  • Streamline file transfers between stages, ensuring only a single COPY . . is required.

@alexevladgabriel alexevladgabriel added the 🐛 bug Something isn't working label Jan 16, 2025
Copy link
Contributor

@alexevladgabriel alexevladgabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuintenQVD0 QuintenQVD0 marked this pull request as ready for review January 16, 2025 07:39
@alexevladgabriel alexevladgabriel merged commit 6b77e69 into pelican-dev:main Jan 16, 2025
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants