PG-1217: Do not try to create keys for existing files #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: the storage manager code uses the same key retrieval logic for mdopen and mdcreate, and this logic creates a new key if we are inside a DDL command that can create files. This means that for ALTERs, if the table is first opened (mdopen) during the ALTER, it creates a key for it, and then it tries to read data from it using decryption, but the data is not actually encrypted. Fix: only create keys for new files, not existing ones.
dAdAbird
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: the storage manager code uses the same key retrieval logic for mdopen and mdcreate, and this logic creates a new key if we are inside a DDL command that can create files.
This means that for ALTERs, if the table is first opened (mdopen) during the ALTER, it creates a key for it, and then it tries to read data from it using decryption, but the data is not actually encrypted.
Fix: only create keys for new files, not existing ones.