IIIF #78 - Resource Status #84
Conversation
… to all gems in Gemfile
…d of Cantaloupe IIIF URLs
…int to Resource edit page
…rom IIIF cache
There was a problem hiding this comment.
Code looks good! Two questions:
- Are we leaving the two
CANTELOUPE_*environment variables spelled that way for legacy reasons? I would recommend making them all spelled consistently (I also see a comment that says "Cantalope") but not a big deal. I know it would likely mean updating every Heroku instance, potentially including some we don't control… - Did you want me to pull locally and test? I'll be really curious to see how the user-controlled conversion and cache busting works in staging!
Good call. I was really just hoping to not have to track down all the places those variables are used 😞, but it looks as though they are only passed through to the Docker image of Cantaloupe. These environment variables are actually only used for the running IIIF Cloud via Docker (they're passed to the Cantaloupe image), so nothing we actually need to upgrade on Heroku. In the release notes for the next release I can note this as a breaking change so that any self-hosted instances can update accordingly before pulling the new version.
Probably not necessary, as there shouldn't be any breaking changes, but feel free if you'd like! |
|
Looks good! 👍 and good catch on the other typos too! |
This pull request addresses #78, #79, and #81 by adding the "Attachments" section to the Resource edit page. The section will display the AWS object key, file size, and content type of both the source image and the converted PTIF (if applicable).
Admin users will also have the ability to convert the source image to a PTIF using the "Convert" button.
Admin users will also have the ability to remove the content from the IIIF cache using the "Clear Cache" button.